Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 0.2.0 #1

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Update to 0.2.0 #1

merged 3 commits into from
Apr 12, 2021

Conversation

leouieda
Copy link
Member

The bot didn't seem to pick this up so I'm doing it manually. Had to tweak the package URL since we had some trouble with the PyPI release and were forced to add a -1 to it.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

leouieda added 2 commits April 10, 2021 15:20
@leouieda
Update harmonica to 0.2.0
bbe621f 
Needed to change the PyPI link since there was an error with the
original release and we had to add a -1 to the tarball.
@leouieda
MNT: Re-rendered with conda-build 3.20.4, conda-smithy 3.10.0, and co…
b4bca25 
…nda-forge-pinning 2021.04.09.17.43.25
@leouieda leouieda requested a review from santisoler as a code owner April 10, 2021 14:25
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ocefpaf
ocefpaf reviewed Apr 10, 2021
View reviewed changes
recipe/meta.yaml Outdated
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 552fb15217de85736dc7fea045feccc4c5a4bec3d6b25e617124f6fd633c288f
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}-1.tar.gz
sha256:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a checksum here. Also I'm not sure that ver-1 is a pep440 valid version. Maybe we should raise that upstream.

@leouieda
Copy link
Member Author

leouieda commented Apr 11, 2021 •
edited
Loading

Ah right, I forgot to paste the hash... Thanks for catching that @ocefpaf 🙂

@santisoler maybe we should just release 0.2.1 just to fix these things.

@santisoler
Copy link
Contributor

Also I'm not sure that ver-1 is a pep440 valid version. Maybe we should raise that upstream.

The -1 is not part of the version number, but the number of the build uploaded to PyPI. I had to re upload the build because of a minor mistake, so I followed pypa/packaging-problems#74 (comment) . But if this is problematic, we can release v0.2.1 and publish that one.

santisoler
santisoler reviewed Apr 12, 2021
View reviewed changes
@leouieda
Copy link
Member Author

Let's merge this and see what happens. If there is a problem we can make a new release.

@leouieda leouieda merged commit 76e2310 into conda-forge:master Apr 12, 2021
@leouieda leouieda deleted the update branch April 12, 2021 15:20
@leouieda leouieda mentioned this pull request Apr 14, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf left review comments

@santisoler santisoler santisoler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leouieda @conda-forge-linter @santisoler @ocefpaf