-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for hdf51122 fixed #119
Rebuild for hdf51122 fixed #119
Conversation
…nda-forge-pinning 2022.07.27.20.15.04
…nda-forge-pinning 2022.08.13.16.03.46
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Python's ctypes.CDLL can't open cross-compiled libraries
@conda-forge/h5py, this is ready for review, I think (cc @hmaarrfk). |
I'm not sure why cross compiling isn't working for arch and ppc64le. It should in theory work. Travis is quite slow (mostly due to our limited access to it) so for these large build matrices, maybe it is good to do them on azure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Co-authored-by: Mark Harfouche <[email protected]>
From the tiny dataset that this PR represents, the travis-ci build matrix completes faster than the azure build matrix. The linux-ppc64le builds are the slowest, but are still faster than the win-64 builds run on Azure. I appreciate that this is highly dependent on the total job queue on travis-ci, and UK morning/early-afternoon on a Sunday is probably the best time to attempt a large parallel matrix, but even if it is slower in general I prefer simplicity of configuration (using the 'default' provider in |
Thank you for the thorough discussion, I think that this is a fine PR and should be merged. I'll let it sit here until a maintainer sees it. |
Lets move on. The discussion was quite clear that the intention was to use the previous as a crutch, while a real fix is found. Thanks for following through. |
This PR augments #118 with the following fixes
CIBW_ARCHS_MACOS
for osx-arm64 (cherry-pick of 975240b from Draft: try to build aarch and ppc64le #117)hdf5
to the build environment when cross compiling and tell the build script to use itCloses #115
Closes #118
Checklist
conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)