Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

1.27.2 #16

Closed
wants to merge 3 commits into from
Closed

1.27.2 #16

wants to merge 3 commits into from

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Feb 23, 2020

Update to version 1.27.2. Pull in changes from AnacondaRecipes.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

* Rework patches for 1.27.2.
* Use Visual Studio for build on Windows
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Contributor Author

@conda-forge-admin, please rerender

@jjhelmus
Copy link
Contributor Author

Windows and Linux are working. macOS is failing. 😢 . This works on our build machines at Anaconda but the macOS configuration is a bit different than Azure.
If anyone wants work on this feel free.

@hadim
Copy link
Member

hadim commented Mar 7, 2020

Could we merge this? It's better to have an updated package for Linux and Windows and not OSX than no updated package at all no?

@hadim
Copy link
Member

hadim commented Mar 7, 2020

I thought it was blocking for conda-forge/tensorboard-feedstock#37 (comment) but it looks like default is available within conda-forge builds so the build passes.

@hadim
Copy link
Member

hadim commented Mar 7, 2020

@jjhelmus would you mind reviewing conda-forge/tensorboard-feedstock#37 ?

@m-novikov
Copy link

Windows and Linux are working. macOS is failing. cry . This works on our build machines at Anaconda but the macOS configuration is a bit different than Azure.
If anyone wants work on this feel free.

Maybe this advice can help solve macos issue on azure PointCloudLibrary/pcl#2601 (comment)

@jschueller
Copy link
Contributor

jschueller commented Jun 22, 2020

@ocefpaf the remaining PRs can be closed

@ocefpaf
Copy link
Member

ocefpaf commented Jun 22, 2020

Done in #19

Thanks @jjhelmus and @jschueller!

@ocefpaf ocefpaf closed this Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants