Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move capnproto to build reqs for cross-compiling #49

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

jdblischak
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@LehMaxence LehMaxence merged commit 58147b8 into conda-forge:main Oct 7, 2024
6 checks passed
@jdblischak jdblischak deleted the move-capnproto-to-build branch October 7, 2024 17:03
@jakirkham
Copy link
Member

Instead of doing this, would it be possible to build capnproto for the build_platform first? Then if build_platform != target_platform, build capnproto again for the target_platform?

This way we can relax the dependency on capnproto and handle the cross-compilation needs

@jdblischak
Copy link
Member Author

Instead of doing this, would it be possible to build capnproto for the build_platform first? Then if build_platform != target_platform, build capnproto again for the target_platform?

I was just following the TODO in build.sh since I wanted to get rid of the manual mamba install step from the build script. I'll let the feedstock maintainers comment on the suitability/feasibility of your proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants