Disallow changing location for components which do not support style props #6624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbalint
changed the title
#15072 Bundle Size — 58.05MiB (~+0.01%).d938db5(current) vs d1d46c1 master#15070(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
| Current #15072 |
Baseline #15070 |
|
|---|---|---|
 Initial JS |
41.03MiB(~+0.01%) |
41.03MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
18.09% |
17.98% |
| Chunks |
20 |
20 |
| Assets |
22 |
22 |
| Modules |
4166 |
4166 |
| Duplicate Modules |
213 |
213 |
| Duplicate Code |
27.31% |
27.31% |
| Packages |
477 |
477 |
| Duplicate Packages |
70 |
70 |
Bundle size by type 2 changes 1 regression 
1 improvement
| Current #15072 |
Baseline #15070 |
|
|---|---|---|
| JS |
58.04MiB (~+0.01%) |
58.04MiB |
| HTML |
7.37KiB (-0.25%) |
7.39KiB |
Bundle analysis report Branch fix/rearrange-component-no-style... Project dashboard
Generated by RelativeCI Documentation Report issue
ruggi
approved these changes
Nov 8, 2024
seanparsons
approved these changes
Nov 8, 2024
liady
pushed a commit
that referenced
this pull request
Dec 13, 2024
…props (#6624) **Problem:** When a grid contains component items which do not support style props: - changing location should be disabled, because we can not attach the gridRow*, gridColumn* props on the component - reorder should still work, because that just modifies the order of the grid items as siblings **Fix:** I used MetadataUtils.targetRegisteredStyleControlsOrHonoursStyleProps to decide if a component supports the necessary grid placement style props: - if `layout` inspector section is enabled in the component annotations, we should allow changing location - if gridRow/gridColumn/etc props are taken by the component, then we should allow changing location - reorder does not need any constrains, it does not depend on style props **Manual Tests:** I hereby swear that: - [x] I opened a hydrogen project and it loaded - [x] I could navigate to various routes in Play mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When a grid contains component items which do not support style props:
Fix:
I used MetadataUtils.targetRegisteredStyleControlsOrHonoursStyleProps to decide if a component supports the necessary grid placement style props:
layoutinspector section is enabled in the component annotations, we should allow changing locationManual Tests:
I hereby swear that: