Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to open files #45

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Add ability to open files #45

merged 4 commits into from
Jul 1, 2023

Conversation

conaticus
Copy link
Owner

No description provided.

@conaticus conaticus added the enhancement New feature or request label Jun 30, 2023
@conaticus conaticus requested a review from LeoCatsune June 30, 2023 21:34
@conaticus
Copy link
Owner Author

conaticus commented Jun 30, 2023 •
edited
Loading

Found a mistake, also going to change the tauri command to return a string if an error occurs.

LeoCatsune
LeoCatsune previously requested changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@LeoCatsune LeoCatsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks decent, but some changes needed.

@conaticus conaticus dismissed LeoCatsune’s stale review July 1, 2023 10:21

issues resolved

@conaticus conaticus merged commit 80c1145 into dev Jul 1, 2023
@conaticus conaticus mentioned this pull request Jul 1, 2023
Closed
@conaticus conaticus deleted the file_opening branch July 1, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoCatsune LeoCatsune LeoCatsune left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conaticus @LeoCatsune