wasmtime: need to download binaries in build

[madebr]

Specify library name and version: wasmtime/all

wasmtime is packaging binaries, so we need to download the binaries in the build method.

@redradist
This is an important fix for wasmtime.
I also could remove the use of CONAN_COMPILE_DEFINITIONS_WASMTIME in the test package.

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[redradist]

Why not to use set(CMAKE_C_STANDARD 11) at top of file ?

[madebr]

It's an idiom we adopted at cci.
"Modern CMake" is all about using targets and avoiding global variables.

It probably does not matter for such a small example, but most of us believe it's better to use best practices as much as possible.

[redradist]

Seems like it is dirty hack ??

[madebr]

It's a way to alias the packages of gcc and clang.
I couldn't remove self.info.settings.compiler.

I argue it's a clean hack 😛

[uilianries]

I would say to use compatible compilers instead: https://docs.conan.io/en/latest/creating_packages/define_abi_compatibility.html#compatible-compilers

[madebr]

I've done it this way to avoid creating duplicate packages.
Packages with compiler=gcc and compiler=clang will be identical, because nothing is built.

If I understand compatible compiler correctly, then a package for gcc and clang will be created.

[madebr]

I actually used a custom package id: see https://docs.conan.io/en/latest/creating_packages/define_abi_compatibility.html#defining-a-custom-package-id

So not a hack after all. It's documented.

[madebr]

Compatible packages would require me to list all gcc/clang versions that are compatible which does not exist, or will be always incomplete.

[madebr]

Compatible compilers works, but it will cause c3i to generate a package for gcc and clang, which are the same.
So I'd prefer to keep the package_id method as it is now.

[uilianries]

Right, it will generate for both clang and gcc. Indeed using same pkg id will save cci resources.

[conan-center-bot]

All green in build 7 (ad5197b6dfaf955430f6af1971c2a769d9384325):

• wasmtime/0.29.0@:
  All packages built successfully! (All logs)

[redradist]

@madebr Seems like your change from source to binary broke number of configurations https://conan.io/center/wasmtime
For first revision there are much bigger number of different configurations !!

In your revision it is only 6 configurations in your revision https://conan.io/center/wasmtime?version=0.29.0&revision=b298dde16782c9f78164a16db7485e6a vs 32 in my original revision https://conan.io/center/wasmtime?version=0.29.0&revision=8f85e593d7dd82d674b3d722b790ca84 !!

[madebr]

It didn't break them.
What is done here is that all gcc@Linux + clang@Linux combinations are mapped to one single package.
Remember, wasmtime releases only one binary that can be used on Linux.
So it would be a waste of storage to serve multiple copies.
e.g. a package for gcc5@Linux would be the same as a package for clang12@Linux
The same applies for other arch/os/compiler combinations.

I hope this explains everything?

[redradist]

@madebr Yeah, you are right ...
One strange thing I see there is not arm option at least for Linux

[madebr]

The package is not built/served by conan-center, but can be built locally.
Only x86_64 for Linux is built+tested+hosted at the moment: https://github.com/conan-io/conan-center-index/blob/master/docs/supported_platforms_and_configurations.md#linux