add libnoise/1.0.0 #6935
Merged
add libnoise/1.0.0 #6935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SpaceIm
commented
Aug 20, 2021
|
All green in build 2 (
|
madebr
reviewed
Aug 20, 2021
| set(NOISE_SRC_DIR ${CMAKE_CURRENT_SOURCE_DIR}/source_subfolder/noise/src) | ||
|
|
||
| file(GLOB NOISE_SRC_FILES | ||
| ${NOISE_SRC_DIR}/*.cpp |
There was a problem hiding this comment.
The archive contains: src/win32/libnoise.def.
It contains a lot of symbols though.
So I think using WINDOWS_EXPORT_ALL_SYMBOLS is good enough.
As long as there are no static variables not exported.
There was a problem hiding this comment.
Yes you're right. And actually, looking at source code, all symbols are exported anyway. No static variables by the way.
There was a problem hiding this comment.
So let's keep it like it is.
madebr
approved these changes
Aug 20, 2021
SSE4
approved these changes
Aug 21, 2021
prince-chrismc
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.