-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
orc: add version 2.1.0 #26426
base: master
Are you sure you want to change the base?
orc: add version 2.1.0 #26426
Conversation
@@ -8,3 +11,9 @@ sources: | |||
"1.9.5": | |||
url: "https://archive.apache.org/dist/orc/orc-1.9.5/orc-1.9.5.tar.gz" | |||
sha256: "6900b4e8a2e4e49275f4067bd0f838ad68330204305fd3f13a5ec519e9d71547" | |||
patches: | |||
"2.1.0": | |||
- patch_file: "patches/2.1.0-0001-fix-cmake.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch can be removed once 2.1.1 is released.
- patch_file: "patches/2.1.0-0001-fix-cmake.patch" | ||
patch_description: "fix cmake build specific to 2.1.0" | ||
patch_type: "backport" | ||
patch_source: "https://github.com/apache/orc/pull/2108" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes that in the patch but not in the referenced PR will be fixed in this PR: apache/orc#2121
### What changes were proposed in this pull request? Fix all imported libraries of thirdparty dependencies to build in Conan. ### Why are the changes needed? Upgrading the C++ ORC 2.1.0 in Conan will fail due to the CMake refactoring. See conan-io/conan-center-index#26426 ### How was this patch tested? See CIs from Conan: https://github.com/conan-io/conan-center-index/pull/26426/checks?check_run_id=35916226382 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2121 from wgtmac/fix_conan. Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]>
### What changes were proposed in this pull request? Fix all imported libraries of thirdparty dependencies to build in Conan. ### Why are the changes needed? Upgrading the C++ ORC 2.1.0 in Conan will fail due to the CMake refactoring. See conan-io/conan-center-index#26426 ### How was this patch tested? See CIs from Conan: https://github.com/conan-io/conan-center-index/pull/26426/checks?check_run_id=35916226382 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2121 from wgtmac/fix_conan. Authored-by: Gang Wu <[email protected]> Signed-off-by: Gang Wu <[email protected]> (cherry picked from commit 09b0650) Signed-off-by: Gang Wu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wgtmac
LGTM.
Thank you for creating PR!
Unfortunately for you, my review is not a condition to merge PR.
Thank you @toge! |
Summary
Changes to recipe: orc/2.1.0
Motivation
Add the latest version 2.1.0
Details
https://orc.apache.org/news/2025/01/09/ORC-2.1.0/