Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orc: add version 2.1.0 #26426

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

orc: add version 2.1.0 #26426

wants to merge 10 commits into from

Conversation

wgtmac
Copy link
Contributor

@wgtmac wgtmac commented Jan 20, 2025

Summary

Changes to recipe: orc/2.1.0

Motivation

Add the latest version 2.1.0

Details

https://orc.apache.org/news/2025/01/09/ORC-2.1.0/


@@ -8,3 +11,9 @@ sources:
"1.9.5":
url: "https://archive.apache.org/dist/orc/orc-1.9.5/orc-1.9.5.tar.gz"
sha256: "6900b4e8a2e4e49275f4067bd0f838ad68330204305fd3f13a5ec519e9d71547"
patches:
"2.1.0":
- patch_file: "patches/2.1.0-0001-fix-cmake.patch"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch can be removed once 2.1.1 is released.

- patch_file: "patches/2.1.0-0001-fix-cmake.patch"
patch_description: "fix cmake build specific to 2.1.0"
patch_type: "backport"
patch_source: "https://github.com/apache/orc/pull/2108"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that in the patch but not in the referenced PR will be fixed in this PR: apache/orc#2121

wgtmac added a commit to apache/orc that referenced this pull request Jan 22, 2025
### What changes were proposed in this pull request?

Fix all imported libraries of thirdparty dependencies to build in Conan.

### Why are the changes needed?

Upgrading the C++ ORC 2.1.0 in Conan will fail due to the CMake refactoring. See conan-io/conan-center-index#26426

### How was this patch tested?

See CIs from Conan: https://github.com/conan-io/conan-center-index/pull/26426/checks?check_run_id=35916226382

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2121 from wgtmac/fix_conan.

Authored-by: Gang Wu <[email protected]>
Signed-off-by: Gang Wu <[email protected]>
wgtmac added a commit to apache/orc that referenced this pull request Jan 22, 2025
### What changes were proposed in this pull request?

Fix all imported libraries of thirdparty dependencies to build in Conan.

### Why are the changes needed?

Upgrading the C++ ORC 2.1.0 in Conan will fail due to the CMake refactoring. See conan-io/conan-center-index#26426

### How was this patch tested?

See CIs from Conan: https://github.com/conan-io/conan-center-index/pull/26426/checks?check_run_id=35916226382

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2121 from wgtmac/fix_conan.

Authored-by: Gang Wu <[email protected]>
Signed-off-by: Gang Wu <[email protected]>
(cherry picked from commit 09b0650)
Signed-off-by: Gang Wu <[email protected]>
@wgtmac
Copy link
Contributor Author

wgtmac commented Jan 22, 2025

@valgur @ErniGH @danimtb @uilianries @toge @AbrilRBS Could you help review this? Thanks!

@wgtmac wgtmac changed the title add orc/2.1.0 orc: add version 2.1.0 Jan 22, 2025
Copy link
Contributor

@toge toge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgtmac
LGTM.

Thank you for creating PR!
Unfortunately for you, my review is not a condition to merge PR.

@wgtmac
Copy link
Contributor Author

wgtmac commented Jan 26, 2025

Thank you @toge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants