Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcbor: fix shared build #2622

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

intelligide
Copy link
Contributor

Specify library name and version: libcbor/0.7.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

#2578

@conan-center-bot
Copy link
Collaborator

Changes not allowed in build 1:

[docs/error_knowledge_base.md, recipes/glog/all/conanfile.py, recipes/glog/all/patches/fix-cmake.patch, recipes/glog/all/test_package/CMakeLists.txt, recipes/glog/all/test_package/conanfile.py, recipes/glog/all/test_package/test_package.cpp, recipes/libcbor/all/conandata.yml, recipes/libcbor/all/conanfile.py, recipes/libcbor/all/patches/0.7.0/001_fix_shared_build.patch, recipes/libsigcpp/3.0.0/conanfile.py, recipes/libsigcpp/3.0.0/test_package/CMakeLists.txt, recipes/libsigcpp/3.0.0/test_package/conanfile.py, recipes/poco/all/CMakeLists.txt, recipes/poco/all/conandata.yml, recipes/poco/all/conanfile.py, recipes/poco/all/test_package/CMakeLists.txt, recipes/poco/all/test_package/conanfile.py, recipes/restinio/all/conandata.yml, recipes/restinio/all/conanfile.py, recipes/restinio/config.yml, recipes/xkbcommon/all/conanfile.py, recipes/xkbcommon/all/test_package/CMakeLists.txt, recipes/zlib/1.2.11/conanfile.py]

Split them in several pull requests if you are making changes in more than one folder.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (96a0b1c5bf66ad6fa9e172aba4f1f7aed33a333c)! 😊

Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch is good, but it's huge, I hope you will submit it upstream, otherwise it might be hard to maintain

@SSE4 SSE4 requested a review from danimtb August 21, 2020 09:51
@intelligide
Copy link
Contributor Author

patch is good, but it's huge, I hope you will submit it upstream, otherwise it might be hard to maintain

A PR is already open ;) PJK/libcbor#148

@danimtb danimtb merged commit c7bc7e5 into conan-io:master Aug 24, 2020
@intelligide intelligide deleted the fix/libcbor branch August 26, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants