-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow: add version 13.0.0 #19462
arrow: add version 13.0.0 #19462
Conversation
I detected other pull requests that are modifying arrow/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Does conan require a minimum CMake version of 3.15? With the new Arrow release (13.0.0) we do require a minimum CMake version of 3.16, see: apache/arrow#34921 Edit: Add log of error for context:
|
…ersion from conan
This comment has been minimized.
This comment has been minimized.
@raulcd def build_requirements(self):
self.tool_requires("cmake/[>=3.16 <4]") |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 6 (
|
It should be: def build_requirements(self):
if Version(self.version) >= "13.0.0":
self.tool_requires("cmake/[>=3.16 <4]") Indeed before 13.0.0, arrow was requiring CMake >= 3.6: https://github.com/apache/arrow/blob/apache-arrow-12.0.1/cpp/CMakeLists.txt#L18 |
* arrow: add version 13.0.0 * arrow: update minimum cmake version and patch cmake to use required version from conan * arrow: suggested fix adding build_requirements for CMake 3.16 * Revert back cmake_minimum_required
Specify library name and version: arriw/13.0.0