Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow: add version 13.0.0 #19462

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

raulcd
Copy link
Contributor

@raulcd raulcd commented Aug 28, 2023

Specify library name and version: arriw/13.0.0


@ghost
Copy link

ghost commented Aug 28, 2023

I detected other pull requests that are modifying arrow/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@raulcd
Copy link
Contributor Author

raulcd commented Aug 28, 2023

Does conan require a minimum CMake version of 3.15? With the new Arrow release (13.0.0) we do require a minimum CMake version of 3.16, see: apache/arrow#34921

Edit: Add log of error for context:

-- Configuring incomplete, errors occurred!
arrow/13.0.0: 
CMake Error at CMakeLists.txt:18 (cmake_minimum_required):
  CMake 3.16 or higher is required.  You are running version 3.15.7

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Aug 28, 2023
3 tasks
@toge
Copy link
Contributor

toge commented Aug 28, 2023

@raulcd
Thank you for your contribution.
To solve cmake version issue, please add following code in conanfile.py:

    def build_requirements(self):
        self.tool_requires("cmake/[>=3.16 <4]")

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 29, 2023
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @raulcd! (And thanks @toge too for solving their question :))

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (8c2228188794968909877f54da11037ee5bca0bf):

  • arrow/10.0.1:
    All packages built successfully! (All logs)

  • arrow/12.0.1:
    All packages built successfully! (All logs)

  • arrow/12.0.0:
    All packages built successfully! (All logs)

  • arrow/2.0.0:
    All packages built successfully! (All logs)

  • arrow/11.0.0:
    All packages built successfully! (All logs)

  • arrow/10.0.0:
    All packages built successfully! (All logs)

  • arrow/7.0.0:
    All packages built successfully! (All logs)

  • arrow/8.0.1:
    All packages built successfully! (All logs)

  • arrow/1.0.0:
    All packages built successfully! (All logs)

  • arrow/8.0.0:
    All packages built successfully! (All logs)

  • arrow/13.0.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 6 (8c2228188794968909877f54da11037ee5bca0bf):

  • arrow/12.0.1:
    All packages built successfully! (All logs)

  • arrow/12.0.0:
    All packages built successfully! (All logs)

  • arrow/11.0.0:
    All packages built successfully! (All logs)

  • arrow/10.0.0:
    All packages built successfully! (All logs)

  • arrow/10.0.1:
    All packages built successfully! (All logs)

  • arrow/2.0.0:
    All packages built successfully! (All logs)

  • arrow/1.0.0:
    All packages built successfully! (All logs)

  • arrow/7.0.0:
    All packages built successfully! (All logs)

  • arrow/8.0.1:
    All packages built successfully! (All logs)

  • arrow/8.0.0:
    All packages built successfully! (All logs)

  • arrow/13.0.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1ad58e7 into conan-io:master Aug 30, 2023
@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 30, 2023

@raulcd Thank you for your contribution. To solve cmake version issue, please add following code in conanfile.py:

    def build_requirements(self):
        self.tool_requires("cmake/[>=3.16 <4]")

It should be:

    def build_requirements(self):
        if Version(self.version) >= "13.0.0":
            self.tool_requires("cmake/[>=3.16 <4]")

Indeed before 13.0.0, arrow was requiring CMake >= 3.6: https://github.com/apache/arrow/blob/apache-arrow-12.0.1/cpp/CMakeLists.txt#L18

ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
* arrow: add version 13.0.0

* arrow: update minimum cmake version and patch cmake to use required version from conan

* arrow: suggested fix adding build_requirements for CMake 3.16

* Revert back cmake_minimum_required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants