Fix code scanning alert no. 1: Use of Kernel.open or IO.read or similar sinks with a non-constant value
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imilar sinks with a non-constant value Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Deploying compute-toys with
|
| Latest commit: |
6b89829
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41feb0bc.compute-toys.pages.dev |
| Branch Preview URL: | https://alert-autofix-1.compute-toys.pages.dev |
Screenshot from BrowserStackURL: https://41feb0bc.compute-toys.pages.dev/new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/compute-toys/compute.toys/security/code-scanning/1
To fix the problem, we should replace the use of
URI.openwith a safer alternative that does not callKernel.openinternally. Specifically, we can useNet::HTTP.getto fetch the image data from the URL. This approach avoids the security risks associated withKernel.open.We need to:
URI.open(image_url).readcall withNet::HTTP.get(URI.parse(image_url)).net/httplibrary is required at the beginning of the file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.