Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: too many shader compilations #45

Closed
munrocket opened this issue Sep 14, 2023 · 2 comments · Fixed by #218
Closed

Bug: too many shader compilations #45

munrocket opened this issue Sep 14, 2023 · 2 comments · Fixed by #218

Comments

@munrocket
Copy link
Contributor

check dev console on page load.

@davidar
Copy link
Contributor

davidar commented Sep 16, 2023

Yeah, known issue but it's a tricky one to fix, it's due to React triggering updates as it loads all the components. Maybe we could suppress shader compiles until the page has fully loaded? But I'm not entirely sure how to implement that. In any case webgpu should be caching the compiled shaders, so doesn't seem to be a huge issue in practice, though still not ideal

@munrocket
Copy link
Contributor Author

Here they fixed reconciliation https://github.com/pmndrs/its-fine
Maybe we can just use it here?

davidar added a commit that referenced this issue Jan 27, 2025
@davidar davidar linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants