This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Don't Request All Block Transactions #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates our Etheruem Client code to _not_ ask for transactions, since we instead ask for logs via a different API. This should heavily reduce the total size of the responses we're getting from Ethereum, since there could be 100's of unrelated transctions in a given block that we now just get the hashes for. See: https://eth.wiki/json-rpc/API#eth_getblockbynumber
coburncoburn
approved these changes
Jun 24, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates our Etheruem Client code to not ask for transactions, since we instead ask for logs via a different API. This should heavily reduce the total size of the responses we're getting from Ethereum, since there could be 100's of unrelated transctions in a given block that we now just get the hashes for.
See: https://eth.wiki/json-rpc/API#eth_getblockbynumber