This repository has been archived by the owner on Aug 1, 2023. It is now read-only.
Changes after the OZ audit #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hayesgm
reviewed
Mar 16, 2021
ethereum/contracts/Starport.sol
Outdated
| @@ -31,7 +31,6 @@ contract Starport { | |||
| event Unlock(address indexed account, uint amount, address asset); | |||
| event UnlockCash(address indexed account, uint amount, uint128 principal); | |||
| event ChangeAuthorities(address[] newAuthorities); | |||
| event SetFutureYield(uint128 nextCashYield, uint128 nextCashYieldIndex, uint nextCashYieldStart); | |||
There was a problem hiding this comment.
I'm not sure we need to remove this. I think it's fine if both the Starport and Cash Token emit such an event.
|
🫖 [View Integration Test Results](server error: invalid xunit xml) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🫖 [View Integration Test Results](server error: invalid xunit xml) |
This comment has been minimized.
This comment has been minimized.
toninorair
changed the title
This comment has been minimized.
This comment has been minimized.
|
🫖 [View Integration Test Results](server error: invalid xunit xml) |
This comment has been minimized.
This comment has been minimized.
|
🫖 [View Integration Test Results](server error: invalid xunit xml) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🫖 [View Integration Test Results](server error: invalid xunit xml) |
This comment has been minimized.
This comment has been minimized.
jflatow
approved these changes
Mar 17, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for this report https://gist.github.com/jcarpanelli/530f48abbbe89fde8b48beaadc6804eb