Lower Proposal Threshold to 25K #189
Conversation
ratankaliani
force-pushed
the
master
branch
2 times, most recently
from
9e0ecee to
334449c
Compare
ratankaliani
changed the title
networks/mainnet.json
Outdated
| "address": "0x7b5e3521a049C8fF88e6349f33044c6Cc33c113c", | ||
| "contract": "Comptroller", | ||
| "description": "Standard Comptroller Impl" | ||
| } |
There was a problem hiding this comment.
Other changes lgtm but did you have to modify this whole file? 😬
There was a problem hiding this comment.
Cleaned mainnet.json to match the repo's structure of the file, however reverting mainnet-abi.json would bring it out of sync with the current state of protocol on-chain (cc @arr00).
Should I revert mainnet-abi.json to match the current state of master?
There was a problem hiding this comment.
Nice, thank you! I wonder what actually changed in mainnet-abi.json besides the new abi?
There was a problem hiding this comment.
IIRC the existing mainnet-abi.json does not handle GovernorBravo's structure correctly with respect to .scen files, which is why @arr00 recommended using this ABI instead of the existing ABI.
I'm not as familiar with the specific changes to the ABI, but can dive deeper/remove it from this PR if you think we should include what changed in the ABI within this PR. I was running into significant issues testing with the existing ABI, which is why I included it in this PR, so that future devs wouldn't experience similar issues with the ABI. LMK what you think is best!
|
Anything else left on the checklist before merging? |
This PR upgrades the GovernorBravoDelegate contract to reflect the reduction of the minimum "setable" proposal threshold to 1K. Additionally, it adds simulations to test reducing the proposal threshold to 25K and updates the ABI to match Compound's current ABI state (cc @arr00) & updates the address for the GovernorBravoDelegate contract.