Upgrade git action to use new seacrest #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandfox
reviewed
Jul 14, 2023
Yes. It's always the required input field. (drop down menu) |
kevincheng96
pushed a commit
that referenced
this pull request
Jul 17, 2023
* maticx yaml permissions fix * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * updated asset config values * added description
cwang25
added a commit
that referenced
this pull request
Jul 18, 2023
* migration scripts commits * set supply and borrow speeds to be non zero * add diff check * add diff checker * added comments on checks * now scenario run is passing, but with the cost of removing linea's contract addresses from goerli/roots.json * add linea back, but scenario run will fail. But it's not related to arbitrum-goerli * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * Fix unverified Linea Goerli contract issue (#787) * addressed comments * first initial working version of CCTP attestation script to help check with circle attestation status to mint native USDC to destination * attestation script with sending txn on user behalf * fix lint * fix lint * Modified migration from GitHub Actions --------- Co-authored-by: Kevin Cheng <[email protected]> Co-authored-by: GitHub Actions Bot <>
cwang25
added a commit
that referenced
this pull request
Jul 18, 2023
* initial gen * remove files * rename directory * add scenario * upadte deploy script * renamde to usdc.n * added relations for scenario test * add scenario test to CI * add migration scrtips, but just changed the USDC reference address * update migration script * since it's native, we shouldn't need usdc bridge things in migration * try to fix the liquidator scenario errors * intent * change those to be 0 initially * FINALLY scneario passed :D * don't re-deploy bulker * set a number in configuration to make bulker tests pass * set configuration to 0 supply cap for initialization, although it will fail the bulker test * update liquidity pool to use the one with better liquidity * after new pool use better liquidity, now able to bump up the volume * remove v2 rewards config step, crank down borrowMin * update migration description * remove trailing newline * ok need to referencing existing rewards in deploy script to share the rewards' * naming changes * added cctp contracts address to roots and update relayArbitrummessage * add l2 cctp * depositForBurn() to use CCTP to send native USDC to arbitrum comet * finally relayArbitrum works with CCTP * format * update to turn off bridge market's reward speed * fix scenarios and slightly reduced volume in liquidator scenarios (somehow during testing the pool the bot uses to flashloan have been withdrew and don't have full liquidity to cover tests * now it has just enough liquidity to pass the test, reverted the liquidation scenario back to usual amount * address comments: remove network prefixes, move contract import from deploy to migration scripts, move relay specific contracts to relay script * remove network prefixes, and rename bridgeComet to usdceComet * rename/refactor usdc -> usdc.e, and usdc.n -> usdc. Also rename deplyoment name for to and to * luckily by the time of testing now Jul 6th 1:40PM PST, we have enough liquidity in the uniswap USDC.e:USDC pool to cover the unchanged volume liquidation scenarios test * rename usdc.n to usdc * make yarn lint happy * rename bridged version to .e to match with mainnet * ported changes to testnet * update on workflow * hmm the error is gone * change default supply reward speed on new comet to be 0 * move migration steps out of this branch * add readme.md to corner cases when deploy new market on the chain with an existing market already * add line * removed USDC in relations * update version to unblock deploy workerflow for now * use dummy requested_network id * try arbitrum goerli network id right away * change a bit on how it locates the hardhat config base * remove hardcoded network chain-id * no more manual wallet project id input * use env.GOV_NETWORK * GOV_NETWORK got some errors :[ * try this seacrest with fixes * try new seacrest :D * Modified deployment roots from GitHub Actions * Migrate Arbitrum Goerli Native usdc (#779) * migration scripts commits * set supply and borrow speeds to be non zero * add diff check * add diff checker * added comments on checks * now scenario run is passing, but with the cost of removing linea's contract addresses from goerli/roots.json * add linea back, but scenario run will fail. But it's not related to arbitrum-goerli * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * Fix unverified Linea Goerli contract issue (#787) * addressed comments * first initial working version of CCTP attestation script to help check with circle attestation status to mint native USDC to destination * attestation script with sending txn on user behalf * fix lint * fix lint * Modified migration from GitHub Actions --------- Co-authored-by: Kevin Cheng <[email protected]> Co-authored-by: GitHub Actions Bot <> * removed asdf config file that should've been ignored * add native usdc whale for arbitrum goerli --------- Co-authored-by: GitHub Actions Bot <> Co-authored-by: Kevin Cheng <[email protected]>
kevincheng96
pushed a commit
that referenced
this pull request
Jul 19, 2023
* maticx yaml permissions fix * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * updated asset config values * added description
cwang25
added a commit
that referenced
this pull request
Jul 20, 2023
* initial gen * remove files * rename directory * add scenario * upadte deploy script * renamde to usdc.n * added relations for scenario test * add scenario test to CI * add migration scrtips, but just changed the USDC reference address * update migration script * since it's native, we shouldn't need usdc bridge things in migration * try to fix the liquidator scenario errors * intent * change those to be 0 initially * FINALLY scneario passed :D * don't re-deploy bulker * set a number in configuration to make bulker tests pass * set configuration to 0 supply cap for initialization, although it will fail the bulker test * update liquidity pool to use the one with better liquidity * after new pool use better liquidity, now able to bump up the volume * remove v2 rewards config step, crank down borrowMin * update migration description * remove trailing newline * ok need to referencing existing rewards in deploy script to share the rewards' * naming changes * added cctp contracts address to roots and update relayArbitrummessage * add l2 cctp * depositForBurn() to use CCTP to send native USDC to arbitrum comet * finally relayArbitrum works with CCTP * format * update to turn off bridge market's reward speed * fix scenarios and slightly reduced volume in liquidator scenarios (somehow during testing the pool the bot uses to flashloan have been withdrew and don't have full liquidity to cover tests * now it has just enough liquidity to pass the test, reverted the liquidation scenario back to usual amount * address comments: remove network prefixes, move contract import from deploy to migration scripts, move relay specific contracts to relay script * remove network prefixes, and rename bridgeComet to usdceComet * rename/refactor usdc -> usdc.e, and usdc.n -> usdc. Also rename deplyoment name for to and to * luckily by the time of testing now Jul 6th 1:40PM PST, we have enough liquidity in the uniswap USDC.e:USDC pool to cover the unchanged volume liquidation scenarios test * rename usdc.n to usdc * make yarn lint happy * rename bridged version to .e to match with mainnet * ported changes to testnet * update on workflow * hmm the error is gone * change default supply reward speed on new comet to be 0 * move migration steps out of this branch * add readme.md to corner cases when deploy new market on the chain with an existing market already * add line * removed USDC in relations * update version to unblock deploy workerflow for now * use dummy requested_network id * try arbitrum goerli network id right away * change a bit on how it locates the hardhat config base * remove hardcoded network chain-id * no more manual wallet project id input * use env.GOV_NETWORK * GOV_NETWORK got some errors :[ * try this seacrest with fixes * try new seacrest :D * Modified deployment roots from GitHub Actions * Migrate Arbitrum Goerli Native usdc (#779) * migration scripts commits * set supply and borrow speeds to be non zero * add diff check * add diff checker * added comments on checks * now scenario run is passing, but with the cost of removing linea's contract addresses from goerli/roots.json * add linea back, but scenario run will fail. But it's not related to arbitrum-goerli * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * Fix unverified Linea Goerli contract issue (#787) * addressed comments * first initial working version of CCTP attestation script to help check with circle attestation status to mint native USDC to destination * attestation script with sending txn on user behalf * fix lint * fix lint * Modified migration from GitHub Actions --------- Co-authored-by: Kevin Cheng <[email protected]> Co-authored-by: GitHub Actions Bot <> * removed asdf config file that should've been ignored * add native usdc whale for arbitrum goerli --------- Co-authored-by: GitHub Actions Bot <> Co-authored-by: Kevin Cheng <[email protected]>
kevincheng96
added a commit
that referenced
this pull request
Jul 21, 2023
* Deploy Arbitrum goerli for usdc native (#778) * initial gen * remove files * rename directory * add scenario * upadte deploy script * renamde to usdc.n * added relations for scenario test * add scenario test to CI * add migration scrtips, but just changed the USDC reference address * update migration script * since it's native, we shouldn't need usdc bridge things in migration * try to fix the liquidator scenario errors * intent * change those to be 0 initially * FINALLY scneario passed :D * don't re-deploy bulker * set a number in configuration to make bulker tests pass * set configuration to 0 supply cap for initialization, although it will fail the bulker test * update liquidity pool to use the one with better liquidity * after new pool use better liquidity, now able to bump up the volume * remove v2 rewards config step, crank down borrowMin * update migration description * remove trailing newline * ok need to referencing existing rewards in deploy script to share the rewards' * naming changes * added cctp contracts address to roots and update relayArbitrummessage * add l2 cctp * depositForBurn() to use CCTP to send native USDC to arbitrum comet * finally relayArbitrum works with CCTP * format * update to turn off bridge market's reward speed * fix scenarios and slightly reduced volume in liquidator scenarios (somehow during testing the pool the bot uses to flashloan have been withdrew and don't have full liquidity to cover tests * now it has just enough liquidity to pass the test, reverted the liquidation scenario back to usual amount * address comments: remove network prefixes, move contract import from deploy to migration scripts, move relay specific contracts to relay script * remove network prefixes, and rename bridgeComet to usdceComet * rename/refactor usdc -> usdc.e, and usdc.n -> usdc. Also rename deplyoment name for to and to * luckily by the time of testing now Jul 6th 1:40PM PST, we have enough liquidity in the uniswap USDC.e:USDC pool to cover the unchanged volume liquidation scenarios test * rename usdc.n to usdc * make yarn lint happy * rename bridged version to .e to match with mainnet * ported changes to testnet * update on workflow * hmm the error is gone * change default supply reward speed on new comet to be 0 * move migration steps out of this branch * add readme.md to corner cases when deploy new market on the chain with an existing market already * add line * removed USDC in relations * update version to unblock deploy workerflow for now * use dummy requested_network id * try arbitrum goerli network id right away * change a bit on how it locates the hardhat config base * remove hardcoded network chain-id * no more manual wallet project id input * use env.GOV_NETWORK * GOV_NETWORK got some errors :[ * try this seacrest with fixes * try new seacrest :D * Modified deployment roots from GitHub Actions * Migrate Arbitrum Goerli Native usdc (#779) * migration scripts commits * set supply and borrow speeds to be non zero * add diff check * add diff checker * added comments on checks * now scenario run is passing, but with the cost of removing linea's contract addresses from goerli/roots.json * add linea back, but scenario run will fail. But it's not related to arbitrum-goerli * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * Fix unverified Linea Goerli contract issue (#787) * addressed comments * first initial working version of CCTP attestation script to help check with circle attestation status to mint native USDC to destination * attestation script with sending txn on user behalf * fix lint * fix lint * Modified migration from GitHub Actions --------- Co-authored-by: Kevin Cheng <[email protected]> Co-authored-by: GitHub Actions Bot <> * removed asdf config file that should've been ignored * add native usdc whale for arbitrum goerli --------- Co-authored-by: GitHub Actions Bot <> Co-authored-by: Kevin Cheng <[email protected]> * revert some mixed up changes when extracted from #769 * fix name * update reference path * fix lint * Update hardhat.config.ts Co-authored-by: Kevin Cheng <[email protected]> * Update hardhat.config.ts Co-authored-by: Kevin Cheng <[email protected]> * fix error --------- Co-authored-by: Kevin Cheng <[email protected]>
kevincheng96
added a commit
that referenced
this pull request
Aug 24, 2023
* Add MATICx as collateral against polygon usdc (#777) * initial migration script to add maticx as collateral for polygon usdc * add verify block * formatting: white spaces removal * Linting fixes (#783) * minor fix * linting fix * Clean up * maticx proposal fixes (#786) * maticx yaml permissions fix * Upgrade git action to use new seacrest (#782) * upgrade git action to use new seacrest * updated asset config values * added description * Fix liquidition bot scenarios * Fix lint * Maticx refactor (#796) * code refactor * lint fix * removed unwanted code * maticx description changes (#798) --------- Co-authored-by: Manoj Patra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per: https://github.com/hayesgm/seacrest/releases/tag/v2
This PR will update /comet git actions to use the latest version of seacrest.
So can unblock from failing seacrest@v1 due to WalletConnect's breaking changes.
Test run: https://github.com/compound-finance/comet/actions/runs/5548176565