Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLBs without EIPs, Retain EIPs #726

Merged
merged 1 commit into from
Dec 8, 2023
Merged

NLBs without EIPs, Retain EIPs #726

merged 1 commit into from
Dec 8, 2023

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston self-assigned this Dec 7, 2023
@JohnPreston JohnPreston linked an issue Dec 7, 2023 that may be closed by this pull request
[FR] ELBv2 Network LB without using Elastic IP Addresses #724
Closed
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston
Copy link
Member Author

Hello @thorfi
Please have a look at this change. I tested it using my Traefik demo and this worked out great.

thorfi
thorfi approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@thorfi thorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works. Thanks!

@thorfi
Copy link
Contributor

thorfi commented Dec 8, 2023

Fixes #724

@JohnPreston JohnPreston merged commit 9c3be5b into main Dec 8, 2023
@JohnPreston JohnPreston deleted the feature/nlb-without-eip branch December 8, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorfi thorfi thorfi approved these changes

Assignees

@JohnPreston JohnPreston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] ELBv2 Network LB without using Elastic IP Addresses
2 participants
@JohnPreston @thorfi