Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting to encrypted #276

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Defaulting to encrypted #276

merged 3 commits into from
Nov 19, 2020

Conversation

JohnPreston
Copy link
Member

By default, encrypts the DB with default aws managed key.

@JohnPreston JohnPreston added enhancement New feature or request rds AWS RDS labels Nov 19, 2020
@JohnPreston JohnPreston self-assigned this Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #276 (4765f21) into root (87ff32a) will decrease coverage by 1.16%.
The diff coverage is 88.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #276      +/-   ##
==========================================
- Coverage   88.27%   87.11%   -1.17%     
==========================================
  Files          99      121      +22     
  Lines        4358     6138    +1780     
==========================================
+ Hits         3847     5347    +1500     
- Misses        511      791     +280     
Impacted Files Coverage Δ
ecs_composex/vpc/vpc_maths.py 100.00% <ø> (+17.02%) ⬆️
ecs_composex/vpc/vpc_aws.py 25.00% <18.18%> (-67.23%) ⬇️
ecs_composex/vpc/vpc_stack.py 65.00% <25.00%> (-28.23%) ⬇️
ecs_composex/appmesh/appmesh_service.py 82.35% <33.33%> (+0.53%) ⬆️
ecs_composex/common/stacks.py 79.16% <50.00%> (-3.89%) ⬇️
ecs_composex/docdb/docdb_ecs.py 56.66% <56.66%> (ø)
ecs_composex/sns/sns_aws.py 71.42% <71.42%> (ø)
ecs_composex/dns/__init__.py 74.39% <71.87%> (-4.56%) ⬇️
ecs_composex/rds/rds_ecs.py 73.80% <73.17%> (-11.38%) ⬇️
ecs_composex/sqs/sqs_aws.py 73.17% <73.17%> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc55f4b...4765f21. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 82e2086 into root Nov 19, 2020
@JohnPreston JohnPreston deleted the x-rds/encrypted-by-default branch November 19, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rds AWS RDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant