Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging settings #265

Merged
merged 7 commits into from
Nov 18, 2020
Merged

Improved logging settings #265

merged 7 commits into from
Nov 18, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston self-assigned this Nov 18, 2020
@JohnPreston JohnPreston added ecs AWS ECS and services enhancement New feature or request labels Nov 18, 2020
@JohnPreston JohnPreston linked an issue Nov 18, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #265 (cb0459c) into root (87ff32a) will decrease coverage by 1.52%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #265      +/-   ##
==========================================
- Coverage   88.27%   86.74%   -1.53%     
==========================================
  Files          99      121      +22     
  Lines        4358     6142    +1784     
==========================================
+ Hits         3847     5328    +1481     
- Misses        511      814     +303     
Impacted Files Coverage Δ
ecs_composex/vpc/vpc_maths.py 100.00% <ø> (+17.02%) ⬆️
ecs_composex/vpc/vpc_aws.py 25.00% <18.18%> (-67.23%) ⬇️
ecs_composex/vpc/vpc_stack.py 65.00% <25.00%> (-28.23%) ⬇️
ecs_composex/appmesh/appmesh_service.py 82.35% <33.33%> (+0.53%) ⬆️
ecs_composex/docdb/docdb_ecs.py 56.66% <56.66%> (ø)
ecs_composex/sns/sns_aws.py 71.42% <71.42%> (ø)
ecs_composex/dns/__init__.py 74.39% <71.87%> (-4.56%) ⬇️
ecs_composex/rds/rds_ecs.py 73.80% <73.17%> (-11.38%) ⬇️
ecs_composex/sqs/sqs_aws.py 73.17% <73.17%> (ø)
ecs_composex/kms/kms_aws.py 74.19% <74.19%> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3366600...751c507. Read the comment docs.

@JohnPreston
Copy link
Member Author

Deployed and tested.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 5e1ab08 into root Nov 18, 2020
@JohnPreston JohnPreston deleted the feature/services-x-logging branch November 18, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecs AWS ECS and services enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

services::logging::CreateLogGroup
1 participant