Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AppMesh properties keys #262

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston linked an issue Nov 17, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #262 (b3446c8) into root (87ff32a) will decrease coverage by 1.59%.
The diff coverage is 88.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #262      +/-   ##
==========================================
- Coverage   88.27%   86.68%   -1.60%     
==========================================
  Files          99      121      +22     
  Lines        4358     6105    +1747     
==========================================
+ Hits         3847     5292    +1445     
- Misses        511      813     +302     
Impacted Files Coverage Δ
ecs_composex/vpc/vpc_maths.py 100.00% <ø> (+17.02%) ⬆️
ecs_composex/vpc/vpc_aws.py 25.00% <18.18%> (-67.23%) ⬇️
ecs_composex/vpc/vpc_stack.py 65.00% <25.00%> (-28.23%) ⬇️
ecs_composex/appmesh/appmesh_service.py 82.35% <33.33%> (+0.53%) ⬆️
ecs_composex/docdb/docdb_ecs.py 56.66% <56.66%> (ø)
ecs_composex/sns/sns_aws.py 71.42% <71.42%> (ø)
ecs_composex/dns/__init__.py 74.39% <71.87%> (-4.56%) ⬇️
ecs_composex/rds/rds_ecs.py 73.80% <73.17%> (-11.38%) ⬇️
ecs_composex/sqs/sqs_aws.py 73.17% <73.17%> (ø)
ecs_composex/kms/kms_aws.py 74.19% <74.19%> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78bef91...9d7fa07. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 1cfa6b7 into root Nov 17, 2020
@JohnPreston JohnPreston deleted the refactor/appmesh-key-names branch November 17, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align x-appmesh routers/nodes/services to camel case.
1 participant