Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix services attributes #243

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Hotfix services attributes #243

merged 2 commits into from
Nov 10, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added release fix This provides a fix for an open issue labels Nov 10, 2020
@JohnPreston JohnPreston linked an issue Nov 10, 2020 that may be closed by this pull request
Reporting invalid properties for services that are supported in docker-compose #242
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #243 (6a387e6) into root (f50cc81) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             root     #243   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files         113      113           
  Lines        5687     5687           
=======================================
  Hits         4911     4911           
  Misses        776      776
Impacted Files Coverage Δ
ecs_composex/common/compose_services.py 89.35% <ø> (ø)
ecs_composex/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50cc81...6a387e6. Read the comment docs.

@JohnPreston JohnPreston merged commit 02da4e1 into root Nov 10, 2020
@JohnPreston JohnPreston deleted the hotfix/services-attributes branch November 10, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix This provides a fix for an open issue release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reporting invalid properties for services that are supported in docker-compose
1 participant
@JohnPreston