Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing condition when QueueName property is set #210

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added the fix This provides a fix for an open issue label Oct 14, 2020
@JohnPreston JohnPreston self-assigned this Oct 14, 2020
@JohnPreston JohnPreston linked an issue Oct 14, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #210 into root will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             root     #210   +/-   ##
=======================================
  Coverage   88.61%   88.62%           
=======================================
  Files         100      100           
  Lines        4446     4448    +2     
=======================================
+ Hits         3940     3942    +2     
  Misses        506      506           
Impacted Files Coverage Δ
ecs_composex/sqs/sqs_template.py 83.33% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed7d7b...9db0a6e. Read the comment docs.

@JohnPreston JohnPreston merged commit 4171044 into root Oct 14, 2020
@JohnPreston JohnPreston deleted the fix/issue-209 branch October 14, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This provides a fix for an open issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.8.0 ignores SQS QueueName
1 participant