Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature x-s3 #196

Merged
merged 13 commits into from
Oct 19, 2020
Merged

Feature x-s3 #196

merged 13 commits into from
Oct 19, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added the enhancement New feature or request label Oct 9, 2020
@JohnPreston JohnPreston self-assigned this Oct 9, 2020
@JohnPreston JohnPreston linked an issue Oct 9, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #196 into root will increase coverage by 0.11%.
The diff coverage is 90.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             root     #196      +/-   ##
==========================================
+ Coverage   88.70%   88.82%   +0.11%     
==========================================
  Files         101      108       +7     
  Lines        4612     4920     +308     
==========================================
+ Hits         4091     4370     +279     
- Misses        521      550      +29     
Impacted Files Coverage Δ
ecs_composex/rds/rds_aws.py 84.37% <ø> (ø)
ecs_composex/resource_settings.py 100.00% <ø> (ø)
ecs_composex/s3/s3_aws.py 79.41% <79.41%> (ø)
ecs_composex/s3/s3_stack.py 84.09% <84.09%> (ø)
ecs_composex/s3/s3_ecs.py 90.82% <90.82%> (ø)
ecs_composex/ecs_composex.py 88.51% <90.90%> (+0.02%) ⬆️
ecs_composex/s3/s3_template.py 94.25% <94.25%> (ø)
ecs_composex/common/aws.py 92.15% <100.00%> (ø)
ecs_composex/common/compose_resources.py 96.42% <100.00%> (+2.55%) ⬆️
ecs_composex/common/stacks.py 83.19% <100.00%> (+0.14%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230a9d3...03dbdca. Read the comment docs.

@JohnPreston JohnPreston force-pushed the feature/s3 branch 3 times, most recently from e82d042 to e2968a0 Compare October 12, 2020 08:35
@JohnPreston
Copy link
Member Author

Working deployment with lookup buckets.

@JohnPreston JohnPreston changed the title WIP - Feature x-s3 Feature x-s3 Oct 19, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 67cc67e into root Oct 19, 2020
@JohnPreston JohnPreston deleted the feature/s3 branch October 19, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR - x-s3
1 participant