Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: secrets import to services from AWS Secrets Manager #142

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

JohnPreston
Copy link
Member

No description provided.

@JohnPreston JohnPreston added the enhancement New feature or request label Aug 7, 2020
@JohnPreston JohnPreston self-assigned this Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #142 into master will decrease coverage by 0.21%.
The diff coverage is 90.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   89.02%   88.80%   -0.22%     
==========================================
  Files          96       97       +1     
  Lines        4019     4084      +65     
==========================================
+ Hits         3578     3627      +49     
- Misses        441      457      +16     
Impacted Files Coverage Δ
ecs_composex/secrets/secrets_config.py 87.50% <87.50%> (ø)
ecs_composex/ecs/ecs_container_config.py 93.75% <93.33%> (-0.37%) ⬇️
ecs_composex/common/settings.py 78.60% <100.00%> (+0.20%) ⬆️
ecs_composex/ecs/ecs_container.py 96.87% <100.00%> (+0.10%) ⬆️
ecs_composex/ecs/ecs_service.py 91.35% <100.00%> (ø)
ecs_composex/ecs/ecs_template.py 96.22% <100.00%> (ø)
ecs_composex/ecs/ecs_iam.py 74.19% <0.00%> (-16.13%) ⬇️
ecs_composex/iam/__init__.py 66.66% <0.00%> (-14.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41aa31c...763efec. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JohnPreston JohnPreston merged commit 4db8a88 into master Aug 7, 2020
@JohnPreston JohnPreston deleted the feature/secrets/external branch August 7, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant