Fixed EFS Services gen

compose-x · Mar 5, 2024 · ec1dcf6 · ec1dcf6
1 parent 906ef7b
commit ec1dcf6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/ecs_composex/common/settings.py b/ecs_composex/common/settings.py
@@ -384,10 +384,10 @@ def set_efs(self) -> None:
                         "Properties": volume.efs_definition,
                         "MacroParameters": volume.parameters,
                         "Lookup": volume.lookup,
-                        "Services": [
-                            {"name": service.name, "access": "RW"}
+                        "Services": {
+                            service.name: {"Access": "RW"}
                             for service in volume.services
-                        ],
+                        },
                         "Settings": {"Subnets": "StorageSubnets"},
                         "Volume": volume,
                     }

diff --git a/tests/features/features/compose.feature → tests/features/features/efs.feature b/tests/features/features/compose.feature → tests/features/features/efs.feature
@@ -1,7 +1,8 @@
-Feature: ecs_composex.cloudmap
+Feature: ecs_composex.efs
 
-    @compose
-    Scenario Outline: AWS CloudMap network settings
+    @efs
+
+    Scenario Outline: AWS EFS/NFS
         Given I use <file_path> as my docker-compose file and <override_file> as override file
         Then I render the docker-compose to composex to validate
         And I render all files to verify execution

diff --git a/use-cases/blog.features.yml b/use-cases/blog.features.yml
@@ -44,6 +44,8 @@ services:
           size: 1024
       - normal-vol:/var/tmp/shared
       - some-volume:/var/anotherpath:ro
+      - shared-images:/app/images
+
     links:
       - app03:dateteller
     ports: