Improve template instantiate #511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match parameter types to argument types in cases of when the parameter type itself is templated
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // matching parameter and argument types | ||
| // resolving parameter | ||
| const auto* fn_TST = | ||
| fn_arg_type->getAs<clang::TemplateSpecializationType>(); |
There was a problem hiding this comment.
warning: no header providing "clang::TemplateSpecializationType" is directly included [misc-include-cleaner]
fn_arg_type->getAs<clang::TemplateSpecializationType>();
^
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 72.45% 72.58% +0.12%
==========================================
Files 9 9
Lines 3591 3647 +56
==========================================
+ Hits 2602 2647 +45
- Misses 989 1000 +11
|
vgvassilev
reviewed
Feb 26, 2025
| @@ -676,6 +676,15 @@ namespace Cpp { | |||
| const char* m_IntegralValue; | |||
| TemplateArgInfo(TCppScope_t type, const char* integral_value = nullptr) | |||
| : m_Type(type), m_IntegralValue(integral_value) {} | |||
| friend bool operator==(const TemplateArgInfo& lhs, | |||
There was a problem hiding this comment.
Why having a friend operator here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Match parameter types to argument types in cases of when the parameter type itself is templated.
Fixes # (issue)
Helps fix up to 4 tests in cppyy.
Also fixes the compiler-research/cppyy-backend#129 's cling failure.
Please tick all options which are relevant.
Testing
Included tests. I feel codecov will still not be happy. Will add more according to its suggestions.
Checklist