Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Is/Get Pointer & Reference functions #510

Merged

Conversation

Vipul-Cariappa
Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa commented Feb 25, 2025

Description

Add IsPointerType, GetPointerType, IsReferenceType & GetNonReferenceType functions

Fixes # (issue)

Helps fix issues in cppyy.

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Tests included.

Checklist

  • I have read the contribution guide recently

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.45%. Comparing base (2b184ce) to head (e2f3f07).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   72.33%   72.45%   +0.12%     
==========================================
  Files           9        9              
  Lines        3575     3591      +16     
==========================================
+ Hits         2586     2602      +16     
  Misses        989      989              
Files with missing lines Coverage Δ
include/clang/Interpreter/CppInterOp.h 96.29% <ø> (ø)
lib/Interpreter/CppInterOp.cpp 82.66% <100.00%> (+0.14%) ⬆️
Files with missing lines Coverage Δ
include/clang/Interpreter/CppInterOp.h 96.29% <ø> (ø)
lib/Interpreter/CppInterOp.cpp 82.66% <100.00%> (+0.14%) ⬆️

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vipul-Cariappa Vipul-Cariappa merged commit 294da5b into compiler-research:main Feb 26, 2025
73 checks passed
@Vipul-Cariappa Vipul-Cariappa deleted the dev/Pointer-Reference branch February 26, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants