Add GetEnumConstantDatamembers function
#499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
==========================================
+ Coverage 71.17% 71.26% +0.09%
==========================================
Files 9 9
Lines 3552 3564 +12
==========================================
+ Hits 2528 2540 +12
Misses 1024 1024
|
|
clang-tidy review says "All clean, LGTM! 👍" |
Vipul-Cariappa
force-pushed
the
dev/EnumConstant
branch
from
b35b261 to
791cd18
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Feb 13, 2025
lib/Interpreter/CppInterOp.cpp
Outdated
| auto* ED = static_cast<EnumDecl*>(i); | ||
|
|
||
| bool is_class_tagged = ED->isScopedUsingClassTag(); | ||
| if ((is_class_tagged) && !(is_class_tagged && include_class_enum)) |
There was a problem hiding this comment.
Suggested change
| if ((is_class_tagged) && !(is_class_tagged && include_class_enum)) | |
| if (is_class_tagged || !include_class_enum) |
Isn't that what you mean? Only include scoped enums when the user requested?
lib/Interpreter/CppInterOp.cpp
Outdated
Comment on lines
1238
to
1240
| for (auto iterator = ED->enumerator_begin(); | ||
| iterator != ED->enumerator_end(); iterator++) | ||
| datamembers.push_back(*iterator); |
There was a problem hiding this comment.
Suggested change
| for (auto iterator = ED->enumerator_begin(); | |
| iterator != ED->enumerator_end(); iterator++) | |
| datamembers.push_back(*iterator); | |
| std::copy(ED->enumerator_begin(), ED->enumerator_end(), std::back_inserter(dm)); |
Vipul-Cariappa
force-pushed
the
dev/EnumConstant
branch
from
791cd18 to
8e44ab8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (is_class_tagged && !include_enum_class) | ||
| continue; | ||
|
|
||
| std::copy(ED->enumerator_begin(), ED->enumerator_end(), |
There was a problem hiding this comment.
warning: no header providing "std::copy" is directly included [misc-include-cleaner]
lib/Interpreter/CppInterOp.cpp:26:
- #if CLANG_VERSION_MAJOR >= 19
+ #include <algorithm>
+ #if CLANG_VERSION_MAJOR >= 19| continue; | ||
|
|
||
| std::copy(ED->enumerator_begin(), ED->enumerator_end(), | ||
| std::back_inserter(datamembers)); |
There was a problem hiding this comment.
warning: no header providing "std::back_inserter" is directly included [misc-include-cleaner]
lib/Interpreter/CppInterOp.cpp:26:
- #if CLANG_VERSION_MAJOR >= 19
+ #include <iterator>
+ #if CLANG_VERSION_MAJOR >= 19There was a problem hiding this comment.
These are good suggestions...
to resolve all `EnumConstantDecl`s declared in a class
Vipul-Cariappa
force-pushed
the
dev/EnumConstant
branch
from
8e44ab8 to
97c8602
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve all
EnumConstantDecls declared in a class.Fixes # (issue)
1 test at cppyy.
Please tick all options which are relevant.
Testing
Implemented tests.
Checklist