Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unittest cmake and gitignore #453

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Jan 16, 2025

Description

General improvements

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

@aaronj0 aaronj0 force-pushed the unittest-cmake branch 2 times, most recently from 74f58d0 to a311cfd Compare January 16, 2025 09:38
@vgvassilev vgvassilev requested a review from mcbarton January 16, 2025 09:58
@mcbarton
Copy link
Collaborator

@aaronj0 @vgvassilev Almost certainly nothing to do with this PR, but any idea why the coverage report comment is not coming up for this PR? I can see from the ci that the repo is created and uploaded. It is appearing on other recent PRs so a little confused.

@vgvassilev
Copy link
Contributor

No clue, maybe some temporary outage?

@aaronj0
Copy link
Collaborator Author

aaronj0 commented Jan 16, 2025

@aaronj0 @vgvassilev Almost certainly nothing to do with this PR, but any idea why the coverage report comment is not coming up for this PR? I can see from the ci that the repo is created and uploaded. It is appearing on other recent PRs so a little confused.

@mcbarton not sure why, I just rebased, lets see if codecov runs now. Otherwise can you take a look at the PR. I have updated the valgrind command since the CppInterOp tests path has been updated

@mcbarton mcbarton merged commit a6976c0 into compiler-research:main Jan 16, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants