Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ninja for emscripten build of llvm #433

Merged

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

emsdk supports Ninja builds, so this PR switches the ci over the Ninja for hopefully smaller and faster emscripten llvm builds. I have cleared the cache of emscripten llvm builds to check I haven't broken anything. Once the ci passes this PR should be ok to merge.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton requested a review from anutosh491 January 10, 2025 23:46
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.96%. Comparing base (ded27fb) to head (29f1496).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   70.96%   70.96%           
=======================================
  Files           9        9           
  Lines        3541     3541           
=======================================
  Hits         2513     2513           
  Misses       1028     1028           

@anutosh491
Copy link
Collaborator

I shall try this out locally and get back with the reviews.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tell me how this is better than what we already have ? I tried ninja locally and also tried updating the recipe on emscripten-forge. The build took me exactly the same time.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Jan 13, 2025

@anutosh491 locally it won't really make much of a difference unless your low on disk space. Its good for CppInterOps ci since we get a smaller build directory, and therefore it takes up less space in the cache (which we have are all running low on).

@anutosh491
Copy link
Collaborator

I just approved the pr, though I think merging is blocked and conflicts are present.

@mcbarton mcbarton merged commit b769ca5 into compiler-research:main Jan 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants