-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(code-gen): allow 'optional' order by for deletedAt column #725
Conversation
Accidentally added the 'deletedAt' field to the exception list. That exception exists because the internal 'createdAt' & 'updatedAt' will never be 'NULL', so allowing 'ASC NULL LAST' doesn't have any effect on the output. Also made the options named, which may result in a smaller validator output. Removed the 'ASC NULLS LAST' & 'DESC NULLS FIRST' as they are the defaults for 'ASC' and 'DESC'
==== Benchmark result ====
|
==== C8 test coverage ==== |
86eee5a
to
b4e8025
Compare
==== Benchmark result ====
|
==== Benchmark result ====
|
==== C8 test coverage ==== |
==== Benchmark result ====
|
Accidentally added the 'deletedAt' field to the exception list. That exception exists because the internal 'createdAt' & 'updatedAt' will never be 'NULL', so allowing 'ASC NULL LAST' doesn't have any effect on the output.
Also made the options named, which may result in a smaller validator output.
Removed the 'ASC NULLS LAST' & 'DESC NULLS FIRST' as they are the defaults for 'ASC' and 'DESC'