Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): remove getNestedFileGroup #723

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Conversation

dirkdev98
Copy link
Member

The query builder now supports everything you ever need of the getNestedFileGroup function and more. Check the release notes for a migration guide.

The query builder now supports everything you ever need of the `getNestedFileGroup` function and more. Check the release notes for a migration guide.
@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8170  ns/op
router - github path params              100000  iterations   10110  ns/op
compas validator simple                 5000000  iterations     245  ns/op
yup validator simple                     100000  iterations   11985  ns/op
fastest-validator validator simple     10000000  iterations     107  ns/op
compas validator nested                 1000000  iterations    1375  ns/op
yup validator nested                      50000  iterations   46399  ns/op
fastest-validator validator nested      2000000  iterations     537  ns/op
logger - strings                         500000  iterations    2619  ns/op
logger - objects                         500000  iterations    3239  ns/op
logger - deep objects                    200000  iterations    5887  ns/op
uuid                                    5000000  iterations     492  ns/op
uuid.isValid                           10000000  iterations     132  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      19  ns/op

@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 66.77% ( 27862/41730 )
Branches : 62.33% ( 2978 /4778 )
Functions : 68.33% ( 919 /1345 )
Lines : 66.77% ( 27862 /41730 )

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8138  ns/op
router - github path params              200000  iterations   11081  ns/op
compas validator simple                 5000000  iterations     260  ns/op
yup validator simple                     100000  iterations   12278  ns/op
fastest-validator validator simple     10000000  iterations     121  ns/op
compas validator nested                 1000000  iterations    1502  ns/op
yup validator nested                      50000  iterations   38596  ns/op
fastest-validator validator nested      2000000  iterations     552  ns/op
logger - strings                         500000  iterations    2798  ns/op
logger - objects                         500000  iterations    3484  ns/op
logger - deep objects                    500000  iterations    5885  ns/op
uuid                                    5000000  iterations     376  ns/op
uuid.isValid                           10000000  iterations     166  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      20  ns/op

@dirkdev98 dirkdev98 merged commit f405275 into main Feb 24, 2021
@dirkdev98 dirkdev98 deleted the feat/store-remove-nested-fg branch February 24, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant