Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint-config): add support for JSDoc linting #707

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Conversation

dirkdev98
Copy link
Member

This is currently mostly stylish linting, will enforce proper types and stuff later.

The JSDoc linting is currently only enabled in with CI=true, since it is slow.

References #568

This is currently mostly stylish linting, will enforce proper types and stuff later.

The JSDoc linting is currently only enabled in with `CI=true`, since it is slow.

References #568
@dirkdev98 dirkdev98 enabled auto-merge (squash) February 21, 2021 19:02
@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 66.15% ( 25407/38408 )
Branches : 65.12% ( 2774 /4260 )
Functions : 66.93% ( 834 /1246 )
Lines : 66.15% ( 25407 /38408 )

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8133  ns/op
router - github path params              100000  iterations   10780  ns/op
compas validator simple                 5000000  iterations     285  ns/op
yup validator simple                     100000  iterations   14098  ns/op
fastest-validator validator simple     10000000  iterations     121  ns/op
compas validator nested                 1000000  iterations    1505  ns/op
yup validator nested                      50000  iterations   48516  ns/op
fastest-validator validator nested      2000000  iterations     578  ns/op
logger - strings                         500000  iterations    2858  ns/op
logger - objects                         500000  iterations    3519  ns/op
logger - deep objects                    200000  iterations    6599  ns/op
uuid                                    2000000  iterations     556  ns/op
uuid.isValid                           10000000  iterations     148  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                          50000000  iterations      21  ns/op

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    9253  ns/op
router - github path params              100000  iterations   10288  ns/op
compas validator simple                 5000000  iterations     253  ns/op
yup validator simple                     100000  iterations   12599  ns/op
fastest-validator validator simple     10000000  iterations     104  ns/op
compas validator nested                 1000000  iterations    1491  ns/op
yup validator nested                      50000  iterations   46638  ns/op
fastest-validator validator nested      2000000  iterations     547  ns/op
logger - strings                         500000  iterations    2607  ns/op
logger - objects                         500000  iterations    3138  ns/op
logger - deep objects                    500000  iterations    5390  ns/op
uuid                                    5000000  iterations     386  ns/op
uuid.isValid                           10000000  iterations     140  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      19  ns/op

@dirkdev98 dirkdev98 merged commit c14c150 into main Feb 21, 2021
@dirkdev98 dirkdev98 deleted the feat/jsdoc branch February 21, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant