Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code-gen): fix missing relation type in sub query builder #700

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

tjonger
Copy link
Collaborator

@tjonger tjonger commented Feb 19, 2021

The relation type (oneToMany, ManyToOne) was missing for the secondary query builder. This resulted in some null values instead of empty array's ([]), because of some missing coalesce calls.

This is resolved and regenerated for the store package

@tjonger tjonger requested a review from dirkdev98 February 19, 2021 10:04
@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8166  ns/op
router - github path params              200000  iterations   10064  ns/op
compas validator simple                 5000000  iterations     262  ns/op
yup validator simple                     100000  iterations   12413  ns/op
fastest-validator validator simple     10000000  iterations     109  ns/op
compas validator nested                 1000000  iterations    1488  ns/op
yup validator nested                      50000  iterations   47660  ns/op
fastest-validator validator nested      2000000  iterations     559  ns/op
logger - strings                         500000  iterations    2688  ns/op
logger - objects                         500000  iterations    3248  ns/op
logger - deep objects                    500000  iterations    5948  ns/op
uuid                                    2000000  iterations     526  ns/op
uuid.isValid                           10000000  iterations     137  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      20  ns/op

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    9018  ns/op
router - github path params              100000  iterations   10401  ns/op
compas validator simple                 5000000  iterations     259  ns/op
yup validator simple                     100000  iterations   12553  ns/op
fastest-validator validator simple     10000000  iterations     103  ns/op
compas validator nested                 1000000  iterations    1475  ns/op
yup validator nested                      50000  iterations   44420  ns/op
fastest-validator validator nested      2000000  iterations     563  ns/op
logger - strings                         500000  iterations    2706  ns/op
logger - objects                         500000  iterations    3194  ns/op
logger - deep objects                    500000  iterations    5496  ns/op
uuid                                    5000000  iterations     379  ns/op
uuid.isValid                           10000000  iterations     138  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      19  ns/op

@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 66.12% ( 25047/37882 )
Branches : 65.15% ( 2758 /4233 )
Functions : 67.7% ( 828 /1223 )
Lines : 66.12% ( 25047 /37882 )

Copy link
Member

@dirkdev98 dirkdev98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@dirkdev98 dirkdev98 merged commit 7bc0173 into main Feb 19, 2021
@dirkdev98 dirkdev98 deleted the fix/codeGen branch February 19, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants