Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib): remove pipeline from streamToBuffer #687

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Conversation

dirkdev98
Copy link
Member

Just make the code a bit easier to reason about.

Just make the code a bit easier to reason about.
@dirkdev98 dirkdev98 enabled auto-merge (squash) February 14, 2021 15:43
@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8364  ns/op
router - github path params              200000  iterations    9539  ns/op
compas validator simple                 5000000  iterations     266  ns/op
yup validator simple                     100000  iterations   13039  ns/op
fastest-validator validator simple     10000000  iterations     121  ns/op
compas validator nested                 1000000  iterations    1483  ns/op
yup validator nested                      50000  iterations   39212  ns/op
fastest-validator validator nested      2000000  iterations     555  ns/op
logger - strings                         500000  iterations    2788  ns/op
logger - objects                         500000  iterations    3389  ns/op
logger - deep objects                    500000  iterations    5955  ns/op
uuid                                    5000000  iterations     387  ns/op
uuid.isValid                           10000000  iterations     165  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                          50000000  iterations      21  ns/op

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    7964  ns/op
router - github path params              200000  iterations    9393  ns/op
compas validator simple                 5000000  iterations     251  ns/op
yup validator simple                     100000  iterations   11617  ns/op
fastest-validator validator simple     10000000  iterations     109  ns/op
compas validator nested                 1000000  iterations    1330  ns/op
yup validator nested                      50000  iterations   35047  ns/op
fastest-validator validator nested      2000000  iterations     527  ns/op
logger - strings                         500000  iterations    2763  ns/op
logger - objects                         500000  iterations    3367  ns/op
logger - deep objects                    500000  iterations    4791  ns/op
uuid                                    5000000  iterations     471  ns/op
uuid.isValid                           10000000  iterations     156  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      18  ns/op

@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 66.04% ( 24998/37851 )
Branches : 65.13% ( 2757 /4233 )
Functions : 66.99% ( 828 /1236 )
Lines : 66.04% ( 24998 /37851 )

@dirkdev98 dirkdev98 merged commit 245f10a into main Feb 14, 2021
@dirkdev98 dirkdev98 deleted the feat/raw-stream branch February 14, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant