Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-gen: support multiple 'viaXxx' in the query builder #661

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

dirkdev98
Copy link
Member

This works by intersecting the result of multiple traverses. This guarantees the same 'AND' behaviour as usual. It also works when the 'xxIn' property is already set, by converting it inline to a 'select from values' expression.

Closes #660

This works by intersecting the result of multiple traverses. This guarantees the same 'AND' behaviour as usual. It also works when the 'xxIn' property is already set, by converting it inline to a 'select from values' expression.

Closes #660
@dirkdev98 dirkdev98 enabled auto-merge (squash) February 5, 2021 20:03
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    9110  ns/op
router - github path params              100000  iterations   10066  ns/op
compas validator simple                 5000000  iterations     273  ns/op
yup validator simple                     100000  iterations   14168  ns/op
fastest-validator validator simple     10000000  iterations     107  ns/op
compas validator nested                 1000000  iterations    1481  ns/op
yup validator nested                      20000  iterations   50011  ns/op
fastest-validator validator nested      2000000  iterations     565  ns/op
logger - strings                         500000  iterations    3159  ns/op
logger - objects                         500000  iterations    3851  ns/op
logger - deep objects                    500000  iterations    6210  ns/op
uuid                                    5000000  iterations     394  ns/op
uuid.isValid                           10000000  iterations     144  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      18  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    9606  ns/op
router - github path params              100000  iterations   11786  ns/op
compas validator simple                 5000000  iterations     289  ns/op
yup validator simple                     100000  iterations   13865  ns/op
fastest-validator validator simple     10000000  iterations     117  ns/op
compas validator nested                 1000000  iterations    1513  ns/op
yup validator nested                      50000  iterations   46673  ns/op
fastest-validator validator nested      2000000  iterations     583  ns/op
logger - strings                         500000  iterations    3126  ns/op
logger - objects                         500000  iterations    3739  ns/op
logger - deep objects                    200000  iterations    6650  ns/op
uuid                                    2000000  iterations     536  ns/op
uuid.isValid                           10000000  iterations     143  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                          50000000  iterations      20  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

==== C8 test coverage ====
Statements: 65.77% ( 24715/37579 )
Branches : 64.85% ( 2725 /4202 )
Functions : 66.8% ( 825 /1235 )
Lines : 65.77% ( 24715 /37579 )

@dirkdev98 dirkdev98 merged commit 6a798ee into main Feb 5, 2021
@dirkdev98 dirkdev98 deleted the feat/multiple-via branch February 5, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-gen: automagic intersect multiple 'via' queries in the query builder
1 participant