Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: force call setStoreQueries #630

Merged
merged 1 commit into from
Jan 24, 2021
Merged

store: force call setStoreQueries #630

merged 1 commit into from
Jan 24, 2021

Conversation

dirkdev98
Copy link
Member

This may prevent some soft delete bugs. We don't handle the errors thrown if queries is not set, so we should document this!

This may prevent some soft delete bugs. We don't handle the errors thrown if queries is not set, so we should document this!
@dirkdev98 dirkdev98 enabled auto-merge (squash) January 24, 2021 19:52
@github-actions
Copy link
Contributor

==== C8 test coverage ====
Statements: 65.84% ( 24211/36771 )
Branches : 66.15% ( 2677 /4047 )
Functions : 65.48% ( 793 /1211 )
Lines : 65.84% ( 24211 /36771 )

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    7220  ns/op
router - github path params              200000  iterations    7919  ns/op
compas validator simple                 5000000  iterations     214  ns/op
yup validator simple                     100000  iterations   10111  ns/op
fastest-validator validator simple     10000000  iterations     101  ns/op
compas validator nested                 1000000  iterations    1273  ns/op
yup validator nested                      50000  iterations   33801  ns/op
fastest-validator validator nested      5000000  iterations     471  ns/op
logger - strings                         500000  iterations    2473  ns/op
logger - objects                         500000  iterations    2893  ns/op
logger - deep objects                    500000  iterations    4364  ns/op
uuid                                    5000000  iterations     331  ns/op
uuid.isValid                           10000000  iterations     136  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      17  ns/op

@github-actions
Copy link
Contributor

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8491  ns/op
router - github path params              100000  iterations   10215  ns/op
compas validator simple                 5000000  iterations     257  ns/op
yup validator simple                     100000  iterations   13206  ns/op
fastest-validator validator simple     10000000  iterations     119  ns/op
compas validator nested                 1000000  iterations    1389  ns/op
yup validator nested                      50000  iterations   37761  ns/op
fastest-validator validator nested      2000000  iterations     555  ns/op
logger - strings                         500000  iterations    2846  ns/op
logger - objects                         500000  iterations    3417  ns/op
logger - deep objects                    200000  iterations    6194  ns/op
uuid                                    2000000  iterations     577  ns/op
uuid.isValid                           10000000  iterations     172  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      19  ns/op

@dirkdev98 dirkdev98 merged commit 18bf001 into main Jan 24, 2021
@dirkdev98 dirkdev98 deleted the feat/store branch January 24, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant