Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sort/Most Recent to Preview #2963

Merged

Conversation

dealako
Copy link
Member

@dealako dealako commented May 25, 2021

  • While testing update CLA Group template, I noticed that we were not
    returning the most recent CLA template. Updated to look at major, minor,
    and created date fields.
  • For Projects CLA Group API - added a service layer - not sure why we
    didn't have a proper service layer in the first place, that was weird.
    Also, added the ctx variable to the projects cla group repository APIs.
    This impacted a number of files in order to add that silly variable to
    make things consistent. It's done now.

Signed-off-by: David Deal [email protected]

- While testing update CLA Group template, I noticed that we were not
returning the most recent CLA template. Updated to look at major, minor,
and created date fields.
- For Projects CLA Group API - added a service layer - not sure why we
didn't have a proper service layer in the first place, that was weird.
Also, added the ctx variable to the projects cla group repository APIs.
This impacted a number of files in order to add that silly variable to
make things consistent.  It's done now.

Signed-off-by: David Deal <[email protected]>
@dealako dealako merged commit cd9e2c8 into communitybridge:main May 25, 2021
@dealako dealako deleted the feature/pcc-916-regenerate-pdf branch May 25, 2021 23:43
nickmango pushed a commit to nickmango/easycla that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant