Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the # for the frontend to work properly #2520

Merged
merged 1 commit into from
Jan 25, 2021
Merged

adding the # for the frontend to work properly #2520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cla-backend/cla/models/github_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,7 @@ def update_pull_request(installation_id, github_repository_id, pull_request, rep
# specified default value per issue #166
context, body = cla.utils.assemble_cla_status(context_name, signed=True)
sign_url = cla.conf["CLA_LANDING_PAGE"] # Remove this once signature detail page ready.
sign_url = os.path.join(sign_url, "#/")
sign_url = append_project_version_to_url(address=sign_url, project_version=project_version)
cla.log.debug(f'Creating new CLA {state} status - {len(signed)} passed, {missing}, signing url: {sign_url}')
create_commit_status(pull_request, last_commit.sha, state, sign_url, body, context)
Expand Down
1 change: 1 addition & 0 deletions cla-backend/cla/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,7 @@ def get_comment_badge(repository_type, all_signed, sign_url, project_version, mi
if all_signed:
badge_url = f'{CLA_LOGO_URL}/cla-signed.svg'
badge_hyperlink = cla.conf["CLA_LANDING_PAGE"]
badge_hyperlink = os.path.join(badge_hyperlink, "#/")
badge_hyperlink = append_project_version_to_url(address=badge_hyperlink, project_version=project_version)
alt = "CLA Signed"
else:
Expand Down