Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performing ICLA signature no confirmation email dispatch and signed document not added to s3 bucket #4249

Closed
2 of 15 tasks
jarias-lfx opened this issue Feb 16, 2024 · 5 comments
Labels
01 - High High Priority bug Something isn't working CommunityReported

Comments

@jarias-lfx
Copy link

Summary

While performing an ICLA signature. The contributor receives an email with a copy of the document. This is not happening. Also the signed PDF is not attached to S3.

Background

  1. Perform a ICLA signature
  2. Sign the Document using Docusign
  3. Contributor never received an email with a document copy
  4. Signed PDF is not getting attached to S3.

Expected behavior

After signing ICLA the contributor should receive a copy of the signed document and the document should be uploaded to S3.

Environment

Please complete the following information:

  • Environment:
    • ALL
    • DEV
    • STAGING
    • PROD
  • Browser:
    • Chrome/Brave
    • Firefox
    • Opera
    • Vivaldi
    • LibreWolf
    • SRware Iron
    • Dissenter
    • Slimjet
    • Midori
    • Edge
    • Lynx
@jarias-lfx jarias-lfx added bug Something isn't working 01 - High High Priority CommunityReported labels Feb 16, 2024
@jarias-lfx
Copy link
Author

Adding my ICLA test record.

{
 "signature_id": "6e14738e-f121-4043-933c-f16bd064f97d",
 "date_modified": "2024-02-16T19:29:37Z",
 "signature_acl": [
  "github:93140557"
 ],
 "signature_approved": true,
 "signature_callback_url": "https://api-gw.platform.linuxfoundation.org/cla-service/v4/signed/individual/9522512/221058575/1522",
 "signature_document_major_version": 2,
 "signature_envelope_id": "d7d47989-25d5-4ffe-aa7f-a7f1fd58d980",
 "signature_project_id": "d8cead54-92b7-48c5-a2c8-b1e295e8f7f1",
 "signature_reference_id": "04581041-79ab-401b-96be-6b44c85c3a46",
 "signature_reference_type": "user",
 "signature_return_url": "https://github.com/open-telemetry/opentelemetry-rust/pull/1522",
 "signature_return_url_type": "Github",
 "signature_signed": true,
 "signature_sign_url": "https://na3.docusign.net/Signing/MTRedeem/v1/e4fcd2bc-139e-4949-b3ca-374c8fda4979/na?slt=eyJ0eXAiOiJNVCIsImFsZyI6IlJTMjU2Iiwia2lkIjoiOGFlYzFjZjQtYmE4NS00MDM5LWE1MmItYzVhODAxMjA3N2EyIn0.AQYAAAABAAMABwCAUtdxJS_cSAgAgPLo-EYv3EgYAAEAAAAAAAAAIQDqAgAAeyJUb2tlbklkIjoiYzMyZjkwZDAtOGYyMy00MzZhLWFlNTctN2Q1MDgxZGRkZjAxIiwiRXhwaXJhdGlvbiI6IjIwMjQtMDItMTZUMTk6MzM6MjUrMDA6MDAiLCJJc3N1ZWRBdCI6IjIwMjQtMDItMTZUMTk6Mjg6MjUuNDE0MjQ0NCswMDowMCIsIlJlc291cmNlSWQiOiJkN2Q0Nzk4OS0yNWQ1LTRmZmUtYWE3Zi1hN2YxZmQ1OGQ5ODAiLCJSZXNvdXJjZXMiOiJ7XCJFbnZlbG9wZUlkXCI6XCJkN2Q0Nzk4OS0yNWQ1LTRmZmUtYWE3Zi1hN2YxZmQ1OGQ5ODBcIixcIkFjdG9yVXNlcklkXCI6XCI5ZTNmNTBhZC0zOTZkLTRiOGYtOGI3My1mZTE5MzYzZWYwMDlcIixcIlJlY2lwaWVudElkXCI6XCJmMzM4YTFkYS00OWU0LTQyY2EtOTYyZS1kOGYyNWExMzlmNzFcIixcIkZha2VRdWVyeVN0cmluZ1wiOlwidD0yYmRmZmQ0Ni01MzQwLTQyNTAtOWYyNC00YzIwNGE5ZDg5MjVcIixcIkludGVncmF0b3JLZXlcIjpcIjQ1ZGNmM2QxLWI5N2UtNGZjMi1iYTJhLTFjNDMxMTQ5MTU1ZFwiLFwiQ3JlYXRlZEF0XCI6XCIyMDI0LTAyLTE2VDE5OjI4OjI1LjQwNTgxN1pcIn0iLCJUb2tlblR5cGUiOjEsIkF1ZGllbmNlIjoiMjVlMDkzOTgtMDM0NC00OTBjLThlNTMtM2FiMmNhNTYyN2JmIiwiUmVkaXJlY3RVcmkiOiJodHRwczovL05BMy5kb2N1c2lnbi5uZXQvU2lnbmluZy9TdGFydEluU2Vzc2lvbi5hc3B4IiwiSGFzaEFsZ29yaXRobSI6MCwiSGFzaFJvdW5kcyI6MCwiVG9rZW5TdGF0dXMiOjAsIklzU2luZ2xlVXNlIjpmYWxzZX0_AAAaDyQmL9xI.Zhf8DKE4IUWiU-2gDQ75iEj4RZagEO891d_74ionMbqrVvkJxEkJX9rFCaeqlvWMXTFuIR4Oer47HoUgW_e8amm0k0totO-zsmpZpeOBeG38M9A4cLgaZBKH9i8CwNkwNFLAPLWYSFscnYNYaVZ0vKfX2EQ4y2on-j1fETugzoDlgfuxd2IjU4gvamxnM_CgmFNlpuRM_V3gXO2BZQpkDwXYL3CSpk54gaq8e1pSXh5AgUMxvRY3Gc3Zz3twXWmaPdnG4Qb-UdPdf9kygD8QlHlWF19fSAC-HdzFouUdgDSIloUwGs9LZ68e9VqACy2lm6jniS6z5eVdJ1AxecpsxA",
 "signature_type": "cla",
 "signed_on": "2024-02-16T19:29:37Z",
 "sigtype_signed_approved_id": "icla#true#true#04581041-79ab-401b-96be-6b44c85c3a46",
 "user_docusign_date_signed": "2024-02-16T11:29:16.73",
 "user_docusign_name": "Juansebastian Arias",
 "user_docusign_raw_xml": "<?xml version=\"1.0\" encoding=\"utf-8\"?><DocuSignEnvelopeInformation xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xmlns=\"http://www.docusign.net/API/3.0\"><EnvelopeStatus><RecipientStatuses><RecipientStatus><Type>Signer</Type><Email>[email protected]</Email><UserName>Juansebastian Arias</UserName><RoutingOrder>1</RoutingOrder><Sent>2024-02-16T11:28:24.713</Sent><Delivered>2024-02-16T11:28:31.017</Delivered><Signed>2024-02-16T11:29:16.73</Signed><DeclineReason xsi:nil=\"true\" /><Status>Completed</Status><RecipientIPAddress>45.239.65.193</RecipientIPAddress><ClientUserId>6e14738e-f121-4043-933c-f16bd064f97d</ClientUserId><CustomFields /><TabStatuses><TabStatus><TabType>SignHere</TabType><Status>Signed</Status><XPosition>275</XPosition><YPosition>21</YPosition><TabLabel>sign</TabLabel><TabName>Please Sign</TabName><TabValue /><DocumentID>522457</DocumentID><PageNumber>3</PageNumber></TabStatus><TabStatus><TabType>Custom</TabType><Status>Signed</Status><XPosition>252</XPosition><YPosition>163</YPosition><TabLabel>full_name</TabLabel><TabName>Full Name</TabName><TabValue>Juansebastian Arias</TabValue><DocumentID>522457</DocumentID><PageNumber>3</PageNumber><OriginalValue /><CustomTabType>Text</CustomTabType></TabStatus><TabStatus><TabType>Custom</TabType><Status>Signed</Status><XPosition>242</XPosition><YPosition>396</YPosition><TabLabel>country</TabLabel><TabName>Country</TabName><TabValue>Costa Rica</TabValue><DocumentID>522457</DocumentID><PageNumber>3</PageNumber><OriginalValue /><CustomTabType>Text</CustomTabType></TabStatus><TabStatus><TabType>Custom</TabType><Status>Signed</Status><XPosition>117</XPosition><YPosition>279</YPosition><TabLabel>mailing_address2</TabLabel><TabName>Mailing Address</TabName><TabValue>San Jose</TabValue><DocumentID>522457</DocumentID><PageNumber>3</PageNumber><OriginalValue /><CustomTabType>Text</CustomTabType></TabStatus><TabStatus><TabType>Custom</TabType><Status>Signed</Status><XPosition>335</XPosition><YPosition>223</YPosition><TabLabel>mailing_address1</TabLabel><TabName>Mailing Address</TabName><TabValue>Llorente, Tibas</TabValue><DocumentID>522457</DocumentID><PageNumber>3</PageNumber><OriginalValue /><CustomTabType>Text</CustomTabType></TabStatus><TabStatus><TabType>Custom</TabType><Status>Signed</Status><XPosition>242</XPosition><YPosition>452</YPosition><TabLabel>email</TabLabel><TabName>Email</TabName><TabValue>[email protected]</TabValue><DocumentID>522457</DocumentID><PageNumber>3</PageNumber><OriginalValue>[email protected]</OriginalValue><CustomTabType>Text</CustomTabType></TabStatus><TabStatus><TabType>DateSigned</TabType><Status>Signed</Status><XPosition>756</XPosition><YPosition>106</YPosition><TabLabel>date</TabLabel><TabName>Date</TabName><TabValue>2/16/2024 | 11:29 AM PST</TabValue><DocumentID>522457</DocumentID><PageNumber>3</PageNumber></TabStatus></TabStatuses><RecipientAttachment><Attachment><Data>PEZvcm1EYXRhPjx4ZmRmPjxmaWVsZHM+PGZpZWxkIG5hbWU9ImZ1bGxfbmFtZSI+PHZhbHVlPkp1YW5zZWJhc3RpYW4gQXJpYXM8L3ZhbHVlPjwvZmllbGQ+PGZpZWxkIG5hbWU9ImNvdW50cnkiPjx2YWx1ZT5Db3N0YSBSaWNhPC92YWx1ZT48L2ZpZWxkPjxmaWVsZCBuYW1lPSJtYWlsaW5nX2FkZHJlc3MyIj48dmFsdWU+U2FuIEpvc2U8L3ZhbHVlPjwvZmllbGQ+PGZpZWxkIG5hbWU9Im1haWxpbmdfYWRkcmVzczEiPjx2YWx1ZT5MbG9yZW50ZSwgVGliYXM8L3ZhbHVlPjwvZmllbGQ+PGZpZWxkIG5hbWU9ImVtYWlsIj48dmFsdWU+c2FyaWFzQGNvbnRyYWN0b3IubGludXhmb3VuZGF0aW9uLm9yZzwvdmFsdWU+PC9maWVsZD48ZmllbGQgbmFtZT0iRGF0ZVNpZ25lZCI+PHZhbHVlPjIvMTYvMjAyNCB8IDExOjI5IEFNIFBTVDwvdmFsdWU+PC9maWVsZD48L2ZpZWxkcz48L3hmZGY+PC9Gb3JtRGF0YT4=</Data><Label>DSXForm</Label></Attachment></RecipientAttachment><AccountStatus>Active</AccountStatus><FormData><xfdf><fields><field name=\"full_name\"><value>Juansebastian Arias</value></field><field name=\"country\"><value>Costa Rica</value></field><field name=\"mailing_address2\"><value>San Jose</value></field><field name=\"mailing_address1\"><value>Llorente, Tibas</value></field><field name=\"email\"><value>[email protected]</value></field><field name=\"DateSigned\"><value>2/16/2024 | 11:29 AM PST</value></field></fields></xfdf></FormData><RecipientId>f338a1da-49e4-42ca-962e-d8f25a139f71</RecipientId></RecipientStatus></RecipientStatuses><TimeGenerated>2024-02-16T11:29:37.5212473</TimeGenerated><EnvelopeID>d7d47989-25d5-4ffe-aa7f-a7f1fd58d980</EnvelopeID><Subject>EasyCLA: CLA Signature Request for Cloud Native Computing Foundation (CNCF)</Subject><UserName>David Deal</UserName><Email>[email protected]</Email><Status>Completed</Status><Created>2024-02-16T11:28:24.043</Created><Sent>2024-02-16T11:28:24.76</Sent><Delivered>2024-02-16T11:28:31.44</Delivered><Signed>2024-02-16T11:29:16.73</Signed><Completed>2024-02-16T11:29:16.73</Completed><ACStatus>Original</ACStatus><ACStatusDate>2024-02-16T11:28:24.043</ACStatusDate><ACHolder>David Deal</ACHolder><ACHolderEmail>[email protected]</ACHolderEmail><ACHolderLocation>DocuSign</ACHolderLocation><SigningLocation>Online</SigningLocation><SenderIPAddress>18.225.195.34  </SenderIPAddress><EnvelopePDFHash /><CustomFields /><AutoNavigation>true</AutoNavigation><EnvelopeIdStamping>true</EnvelopeIdStamping><AuthoritativeCopy>false</AuthoritativeCopy><DocumentStatuses><DocumentStatus><ID>522457</ID><Name>Apache Style</Name><TemplateName /><Sequence>1</Sequence></DocumentStatus></DocumentStatuses></EnvelopeStatus></DocuSignEnvelopeInformation>"
}

nickmango added a commit to nickmango/easycla that referenced this issue Feb 20, 2024
- Resolved email and dispatch events for docusign auth flow
- Fixed the s3 Upload

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Feb 20, 2024
@nickmango
Copy link
Contributor

@thakurveerendras kindly review

@thakurveerendras
Copy link
Contributor

Tested issue on dev site and found that ICLA signature confirmation email dispatch and signed document also added to s3 bucket
image
image
image

@thakurveerendras
Copy link
Contributor

Tested issue on prod and found that after DocuSign ICLA email invitation with the name "EasyCLA: Individual CLA Signed for Test CLA Group" properly appears.

  • Refer to the video clip:#4249.webm

  • Don't have access to the S3 bucket at prod, So @jarias-lfx kindly confirm this case

  • Able to access the PDF attached on the email link

image

@mlehotskylf
Copy link
Contributor

This is fixed, closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - High High Priority bug Something isn't working CommunityReported
Projects
None yet
Development

No branches or pull requests

4 participants