Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit not authorized on employee acknowledgement flow #3244

Closed
thakurveerendras opened this issue Sep 6, 2021 · 3 comments
Closed

Commit not authorized on employee acknowledgement flow #3244

thakurveerendras opened this issue Sep 6, 2021 · 3 comments
Assignees
@nickmango
Labels
GitLab Integration Features and issues related to GitLab

Comments

@thakurveerendras
Copy link
Contributor

Preconditions : CLA group on which Require corporate contributors to sign Individual CLAs options is not selected

Steps :

  1. Go to corporate console & add GitLab user (thakurveerendras) to approval list
  2. Create MR form approval list user (thakurveerendras)
  3. See-MR is gated
  4. Click on Not Covered
  5. Click on Proceed as a Corporate Contributor options
  6. Select Microsoft Corporation organization
  7. Click on Procced button
  • See- You are done ! confirmation prompt appears

Actual results : Commit is not authorized
image.png

User added in contributor list
image.png
image.png

https://images.zenhubusercontent.com/194341141/0092c8df-e567-4fa1-9422-3715d5235149/employee_acknowledgement_.mp4
@thakurveerendras thakurveerendras added the GitLab Integration Features and issues related to GitLab label Sep 6, 2021
nickmango added a commit to nickmango/easycla that referenced this issue Sep 6, 2021
@nickmango
[communitybridge#3239,communitybridge#3244] Bug/GitLab ECLA (communit…
3f9d6d4 
…ybridge#3238)

- Added v2 endpoint that fetches members of a given group id
- Updated controller for employee ack with right return_url_types(gitlab/github)
- check for gitlab group approval list criteria
nickmango added a commit to nickmango/easycla that referenced this issue Sep 6, 2021
@nickmango
[communitybridge#3239,communitybridge#3244] Bug/GitLab ECLA (communit…
44f58f6 
…ybridge#3238)

- Added v2 endpoint that fetches members of a given group id
- Updated controller for employee ack with right return_url_types(gitlab/github)
- check for gitlab group approval list criteria

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit to nickmango/easycla that referenced this issue Sep 6, 2021
@nickmango
[communitybridge#3239,communitybridge#3244] Bug/GitLab ECLA (communit…
2ac6448 
…ybridge#3238)

- Added v2 endpoint that fetches members of a given group id
- Updated controller for employee ack with right return_url_types(gitlab/github)
- check for gitlab group approval list criteria

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit to nickmango/easycla that referenced this issue Sep 7, 2021
@nickmango
[communitybridge#3239,communitybridge#3244] Bug/GitLab ECLA (communit…
d215091 
…ybridge#3238)

- Added v2 endpoint that fetches members of a given group id
- Updated controller for employee ack with right return_url_types(gitlab/github)
- check for gitlab group approval list criteria

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Sep 7, 2021
@nickmango
Merge pull request #3245 from nickmango/feature/ecl-gitlab-grp
d4b24e3 
[#3239,#3244] Bug/GitLab ECLA (#3238)
@thakurveerendras
Copy link
Contributor Author

Hi @nickmango
Commit is still not authorized as reported, Refer Video clip:
https://images.zenhubusercontent.com/194341141/ef7937d9-065c-4121-8227-3889991e4e84/3244.mp4

@thakurveerendras
Copy link
Contributor Author

Issue is still reproducible as reported on fresh setup,
Refer video clip :
https://images.zenhubusercontent.com/194341141/d16d61a0-bb6c-40b5-be72-ef5634e0bf7d/empack_gitlabuser.mp4

@thakurveerendras thakurveerendras mentioned this issue Sep 13, 2021
Closed
nickmango added a commit to nickmango/easycla that referenced this issue Sep 13, 2021
@nickmango
[communitybridge#3244,communitybridge#3271] Bug/Gitlab Employee ack
3b7cadf 
- Resolved issue raised on MR update for new employee flow

Signed-off-by: Harold Wanyama <[email protected]>
nickmango added a commit that referenced this issue Sep 13, 2021
@nickmango
Merge pull request #3273 from nickmango/bug/ecla-gitlab-request
4869c96 
[#3244,#3271] Bug/Gitlab Employee ack
@thakurveerendras
Copy link
Contributor Author

@nickmango ,
Issue is tested on dev site & found that it is fixed as expected, Now MR is updated after complete employee Acknowledgement flow. So making issue status QA-Done

Refer Video clip :
https://images.zenhubusercontent.com/194341141/ab8f4db4-000f-463d-8fc1-4c5a3fb1c494/3244__1_.mp4

@dealako dealako closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickmango nickmango

Labels
GitLab Integration Features and issues related to GitLab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dealako @thakurveerendras @nickmango