Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to sign CCLA with designated CLA Manager (who doesn't have LFID) #2636

Closed
ashav-github opened this issue Feb 13, 2021 · 7 comments
Closed
Assignees
Labels
bug Something isn't working tier-1 An issue or feature that is considered a tier 1 priority issue v2

Comments

@ashav-github
Copy link

ashav-github commented Feb 13, 2021

Unable to sign CCLA. Also, CLA Manager and CLA Signatory role is not assigned in IAM to the user (doesn't have LF ID) who is elected as CLA Manager by a contributor while signing CCLA.

Pre-condition: Have a Standalone project created with Entity Type=Series LLC. Parent and Legal Parent = LF Projects, LLC

Steps:

  1. Login to Admin Console and create a CLA group for the standalone project.
  2. Configure Github org and install EasyCLA bot.
  3. Login to Github as a contributor and create a new org, select someone else as CLA Manager who doesn't have LF ID.
  4. The invited user will receive an email with subject line: 'EasyCLA: Invitation to create LF Login and complete process of becoming CLA Manager for project: LF Projects, LLC'
  5. Accept the invite and create a new LF account, verify your email->this will take you to inside the corporate console
  6. Search for the standalone project which you want to sign CCLA (Note: the email doesn't mention about the project name)
  7. Click on Sign CCLA and proceed till you reach the 'Generating Document' step

Actual Result: It throws error message at this step 'CLA System is not able to support your request. Please Click here to open a support ticket.'
If you check IAM, the user doesn't get CLA Manager and CLA Signatory. He has cla-manager-designee role.

image.png

Expected Result: CLA Manager should be able to sign CCLA without any error.

@vinod-kadam vinod-kadam changed the title Unable to sign CCLA. Also, CLA Manager and CLA Signatory role is not assigned in IAM to the user (doesn't have LF ID) who is elected as CLA Manager by a contributor while signing CCLA. Unable to sign CCLA with designated CLA Manager Feb 13, 2021
@vinod-kadam vinod-kadam added tier-1 An issue or feature that is considered a tier 1 priority issue v2 bug Something isn't working labels Feb 13, 2021
@dealako
Copy link
Member

dealako commented Feb 13, 2021

For helping track down these issues, it would be helpful to enumerate the details:

  • Environment: Staging
  • Project AshaSfF2
  • Company: Delightful Gourmet Pvt Ltd
  • User: ?
  • SFIDs: 092M00001lkOVVQA3 a097c000007oSe2AAE c970f92a-8347-482a-9b4b-60b4880ee56e

@dealako
Copy link
Member

dealako commented Feb 13, 2021

Trying to track this CCLA signing request down. Can't seem to find an error.

2021-02-13T09:41:11 DEBUG cla: populate_sign_url - company - generating a docusign signer object with name: Asha clatest, email: [email protected]

wanyaland added a commit that referenced this issue Feb 15, 2021
- Resolved CCLA sign issue for standalone projects

Signed-off-by: wanyaland <[email protected]>
wanyaland added a commit that referenced this issue Feb 15, 2021
@wanyaland
Copy link
Contributor

@david.. I happened to reproduce this issue and the root cause was getting cla-group for a project under LF Project, LLC. The child project used LFProject, LLC in the mappings records query

@vinod-kadam
Copy link

As updated by @wanyaland , this is deployed to DEV & Staging.

@vinod-kadam vinod-kadam changed the title Unable to sign CCLA with designated CLA Manager Unable to sign CCLA with designated CLA Manager (who doesn't have LFID) Feb 15, 2021
@vinod-kadam
Copy link

After Harold confirmed that fix is deployed to Staging, I tried it for a designed CLA Manager who has LFID & it worked fine for me on Staging,
@ashav-github to try it for designed CLA Manager who doesn't have LFID.

@ashav-github
Copy link
Author

@vinod-kadam @wanyaland I retested this on Stage and its working fine now.
Test Data: New org created: Nykaa | NewLF ID: ashav.nykaa | LF Email: [email protected] | GH Repo: ashav-test-stgfeb1-org1/stgfeb1-repo1

@vinod-kadam
Copy link

This is deployed to PROD as well.

@dealako dealako closed this as completed Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tier-1 An issue or feature that is considered a tier 1 priority issue v2
Projects
None yet
Development

No branches or pull requests

4 participants