Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signed CLA is showing up as not signed on Corporate Console #2515

Closed
vinod-kadam opened this issue Jan 22, 2021 · 4 comments
Closed

Signed CLA is showing up as not signed on Corporate Console #2515

vinod-kadam opened this issue Jan 22, 2021 · 4 comments
Assignees
@wanyaland @manishv09
Labels
bug Something isn't working tier-1 An issue or feature that is considered a tier 1 priority issue v2

Comments

@vinod-kadam
Copy link

This issue is seen on Staging environment.

I signed a CCLA for vinodkfoundation_child1 project for "Proxima India" (it is a signing entity name in company Proxima) however the CCLA is shown as not signed on Corporate Console
image.png

When I go from Contributor Console & select "Proxima India"; it gives presents me the list of CLA managers which means CLA is signed.
image.png

CLA group information can be found below:
image.png

I called the following API from postman:
https://api-gw.staging.platform.linuxfoundation.org/cla-service/v4/company/0012M00002MnADGQA3/project/a097c000007nhFnAAI/cla
I got the following response:
{
"signed_cla_list": [],
"unsigned_project_list": [
{
"can_sign": true,
"ccla_enabled": true,
"cla_group_id": "043637e9-1a8f-4082-9a45-db1fa7d7f0dd",
"cla_group_name": "vinodkfoundation_clagroup1",
"icla_enabled": true,
"project_name": "vinodkfoundation_child1",
"project_sfid": "a097c000007nhFnAAI",
"sub_projects": []
}
]
}
@vinod-kadam vinod-kadam added bug Something isn't working tier-1 An issue or feature that is considered a tier 1 priority issue v2 labels Jan 22, 2021
wanyaland added a commit that referenced this issue Jan 24, 2021
@wanyaland
[#2515] Feature/Company Sign status
142b58b 
- Refactored GET for company, project CLAs by leveraging signing entity name
- Updated response with multiple companies

Signed-off-by: wanyaland <[email protected]>
dealako pushed a commit that referenced this issue Jan 24, 2021
@wanyaland
[#2515] Feature/Company Sign status (#2517)
05d3d7d 
- Refactored GET for company, project CLAs by leveraging signing entity name
- Updated response with multiple companies

Signed-off-by: wanyaland <[email protected]>
wanyaland added a commit that referenced this issue Jan 25, 2021
@wanyaland
[#2515] Feature/ Company Project CLA
8887b7e 
- Added company_id and signatureACL to response

Signed-off-by: wanyaland <[email protected]>
dealako pushed a commit that referenced this issue Jan 25, 2021
@wanyaland
[#2515] Feature/ Company Project CLA (#2521)
8742a10 
- Added company_id and signatureACL to response

Signed-off-by: wanyaland <[email protected]>
wanyaland added a commit that referenced this issue Jan 26, 2021
@wanyaland
[#2515] Feature/ Get Events Signing Entity Name
163b9bd 
- Factored in internal companyID based on signing entity name to fetch corresponding events

Signed-off-by: wanyaland <[email protected]>
dealako pushed a commit that referenced this issue Jan 26, 2021
@wanyaland
[#2515] Feature/ Get Events Signing Entity Name (#2522)
4ce9b75 
- Factored in internal companyID based on signing entity name to fetch corresponding events

Signed-off-by: wanyaland <[email protected]>
wanyaland added a commit that referenced this issue Jan 26, 2021
@wanyaland
[#2515] Feature/Query for Company ID
ae10efe 
- Added query param for company ID for company project cla endpoint

Signed-off-by: wanyaland <[email protected]>
dealako pushed a commit that referenced this issue Jan 26, 2021
@wanyaland
[#2515] Feature/Query for Company ID (#2525)
276a005 
- Added query param for company ID for company project cla endpoint

Signed-off-by: wanyaland <[email protected]>
wanyaland added a commit that referenced this issue Jan 28, 2021
@wanyaland
[#2515] Bug/Events and Contributors for Company and Project
0158b73 
- Resolved events endpoint caused by incorrect filter attribute changed to event_company_id
- Updated company project contributors endpoint with internal companyID as path parameter

Signed-off-by: wanyaland <[email protected]>
dealako pushed a commit that referenced this issue Jan 28, 2021
@wanyaland
[#2515] Bug/Events and Contributors for Company and Project (#2534)
dbf2b37 
- Resolved events endpoint caused by incorrect filter attribute changed to event_company_id
- Updated company project contributors endpoint with internal companyID as path parameter

Signed-off-by: wanyaland <[email protected]>
@vinod-kadam
Copy link
Author

All CLA backend changes have been deployed to Dev.
Also, Corporate Console changes (https://jira.linuxfoundation.org/browse/LFX-3064) have been deployed to Dev.

@vinod-kadam vinod-kadam assigned manishv09 and unassigned dealako Jan 28, 2021
@manishv09
Copy link

Working fine on DEV and found it is working. With existing data and found working as expected.
image.png

@vinod-kadam
Copy link
Author

@manishv09 as discussed try it also for a new org after new org creation issue is resolved & deployed to Dev.

@vinod-kadam
Copy link
Author

Closing this ticket since it was updated on 2-Feb that signing entity name will not be shown on the UI anywhere - system will return to its old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wanyaland wanyaland

@manishv09 manishv09

Labels
bug Something isn't working tier-1 An issue or feature that is considered a tier 1 priority issue v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dealako @wanyaland @vinod-kadam @manishv09