adding the # for the frontend to work properly (#2520)

Signed-off-by: makkalot <[email protected]>
communitybridge · Jan 25, 2021 · 997dd96 · 997dd96
1 parent ecfe533
commit 997dd96
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/cla-backend/cla/models/github_models.py b/cla-backend/cla/models/github_models.py
@@ -1033,6 +1033,7 @@ def update_pull_request(installation_id, github_repository_id, pull_request, rep
             # specified default value per issue #166
             context, body = cla.utils.assemble_cla_status(context_name, signed=True)
             sign_url = cla.conf["CLA_LANDING_PAGE"]  # Remove this once signature detail page ready.
+            sign_url = os.path.join(sign_url, "#/")
             sign_url = append_project_version_to_url(address=sign_url, project_version=project_version)
             cla.log.debug(f'Creating new CLA {state} status - {len(signed)} passed, {missing}, signing url: {sign_url}')
             create_commit_status(pull_request, last_commit.sha, state, sign_url, body, context)

diff --git a/cla-backend/cla/utils.py b/cla-backend/cla/utils.py
@@ -827,6 +827,7 @@ def get_comment_badge(repository_type, all_signed, sign_url, project_version, mi
     if all_signed:
         badge_url = f'{CLA_LOGO_URL}/cla-signed.svg'
         badge_hyperlink = cla.conf["CLA_LANDING_PAGE"]
+        badge_hyperlink = os.path.join(badge_hyperlink, "#/")
         badge_hyperlink = append_project_version_to_url(address=badge_hyperlink, project_version=project_version)
         alt = "CLA Signed"
     else: