Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vikunja install script to prevent database deletion upon updating #524

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

vhsdream
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

This PR addresses an issue in which the Vikunja database (and files folder if created) gets deleted when the user updates Vikunja via the script. The change adds two more substitutions via the sed command to modify the default Vikunja config file; changes the location of the database file and the files folder to /etc/vikunja.

Fixes #502

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation) - There is none, as far as I can tell.

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

  • Related PR #

@vhsdream vhsdream requested a review from a team as a code owner November 26, 2024 01:05
@github-actions github-actions bot added the update script A change that updates a script label Nov 26, 2024
havardthom
havardthom previously approved these changes Nov 26, 2024
MickLesk
MickLesk previously approved these changes Nov 26, 2024
@MickLesk MickLesk merged commit 9795d41 into community-scripts:main Nov 26, 2024
1 check passed
@vhsdream vhsdream deleted the vikunja branch November 26, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vikunja update wont save data
3 participants