Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New script: listmonk LXC #442

Merged
merged 4 commits into from
Nov 24, 2024
Merged

New script: listmonk LXC #442

merged 4 commits into from
Nov 24, 2024

Conversation

bvdberg01
Copy link
Contributor

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Adding script for listmonk as requested in discussion #427.

I tested installation on my Proxmox installation but cannot test all functionality because I don't use this app. The update script is also tested by installing an older version from listmonk on install (changing line 40 in install/listmonk-install.sh to RELEASE="3.0.0") and then running the update script.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)
  • Documentation updated (I have updated any relevant documentation)

Additional Information (optional)

Installed listmonk LXC:
image

Running update script:
image

Running update script on latest version:
image

Running listmonk:
image

@bvdberg01 bvdberg01 requested a review from a team as a code owner November 22, 2024 20:51
@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Nov 22, 2024
@MickLesk
Copy link
Member

Thank you for the submission 👍
I won't get around to reviewing it fully until tomorrow.

Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments :-)

havardthom
havardthom previously approved these changes Nov 24, 2024
Co-Authored-By: Håvard Gjøby Thom <[email protected]>
havardthom
havardthom previously approved these changes Nov 24, 2024
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Copy link
Contributor

@havardthom havardthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@havardthom havardthom merged commit 7ffd6cb into community-scripts:main Nov 24, 2024
1 check passed
@mnlxr
Copy link

mnlxr commented Nov 25, 2024

Thank you .You are really awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new script A change that adds a new script website A change to the website
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants