-
-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dash "-" with "/" in metadata #374
Replace dash "-" with "/" in metadata #374
Conversation
i actually really like the "&" symbol, can we get some more opinions on this? i do agree that it at least needs to be change from "-" |
If the & symbol was used, which was my first try, then "Matter / Zigbee / ZWave" can stay the same other than including spaces. |
Yeah, that seems like the best option in my opinion. I prefer using ‘&’ because it reads better, its like saying ‘Pi-hole and DNS’ instead of ‘Pi-hole … DNS’ but i.g its all personal preference so keep Matter / Zigbee / ZWave the same and change the others to &? thats my proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both works for me
c983cbe
Ok folks, & it is :) This change just needs reapproval please @havardthom @MickLesk . Can be viewed here: https://newzealandpaul.github.io/ProxmoxVE/scripts I went with "Matter, Zigbee & ZWave" as I just think this makes more sense and reads like how someone would describe the category "Matter, Zigbee and ZWave". For another discussion but I personally would rename this "Home Automation" but thats a discussion for another day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me
Note
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.
Description
Categories currently use the dash "-" symbol to represent shorthand "and" in category names in the metadata.
This is contra to normal English language usage and informal web usage where "-" is usually used to denote a category, or sub-category.
In informal english language "/" usually means logical "or" (a set encompassing all of A, all of B including all of A and B).
I also think it looks better.
Matter/Zigbee/Zwave was renamed to continue to make sense.
I have some further taxonomical changes I want to suggest but this needs to be first to avoid conflicting PR.
Screenshot:
You can have a look at a demo of it here (Edit: I use my main branch for testing so might not always be the demo):
https://newzealandpaul.github.io/ProxmoxVE/scripts
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
I also tried "&" symbol and it didn't look as nice.