Massive Update - Remove old storage check, add new storage and resource check to all scripts - Remove downscaling with pct set

[MickLesk]

Description

Massive Update (Remove StorageCheck (old) + Add Ressource & StorageCheck, Remove Whiptail, Remove PCT Ressource Set

Type of change

Please check the relevant option(s):

• Bug fix (non-breaking change that resolves an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
• New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

• Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
• Testing performed (I have tested my changes, ensuring everything works as expected)
• Documentation updated (I have updated any relevant documentation)

Related Pull Requests / Discussions

If there are other pull requests or discussions related to this change, please link them here:

• (Add Option "check_storage" and "check_container_ressources" #249)

[remz1337]

Awesome work. I'm supportive of the usage of the new centralized functions (check_ressources). However, can we discuss the PCT set resources? Personnaly, I hate having my LXC overprovisioned. I would prefer to keep that part.

[MickLesk]

Yes we can discuss, but the right thing to do in my opinion would be to make a small fix PR, with proper resources. In the end, Proxmox and the LXC only use what it actually needs :-) if it doesn't need it, it doesn't use it. (Unlike with Homeassistant VM 😂)

[havardthom]

Nice, only comments on moving the functions before app installation and whiptail in some scripts. I tested moving header_info before whiptail in cockpit script locally and it worked fine.
Also have you tested that check_container_storage and check_container_resources works on all supported distributions?

debian 11
debian 12
ubuntu 20.04
ubuntu 22.04
ubuntu 24.04

[MickLesk]

Jep, local it works for Fedora and co too. Thats a later PR. For now only all Debian & Ubuntu Systems

[MickLesk]

@havardthom all done.

[newzealandpaul]

Awesome work. I'm supportive of the usage of the new centralized functions (check_ressources). However, can we discuss the PCT set resources? Personnaly, I hate having my LXC overprovisioned. I would prefer to keep that part.

...

Yes we can discuss, but the right thing to do in my opinion would be to make a small fix PR, with proper resources. In the end, Proxmox and the LXC only use what it actually needs :-) if it doesn't need it, it doesn't use it. (Unlike with Homeassistant VM 😂)

For setups with limited resources, it does make sense to not over-provision. If for example I try a script that ends up consuming a lot more storage when in use (this happened to me a few days ago) I would rather that new LXC crashed, than my long running LXCs.

[newzealandpaul]

Code looks fine and will approve, but I don't think our policy should be over provisioning LXC.