-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix crash instantiating ctkDICOMBrowser #977
BUG: Fix crash instantiating ctkDICOMBrowser #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since ctkFileDialog
(see [1]) already has an ivar called UsingNativeDialog
, what about adding a convenience getter called ctkFileDialog::isUsingNativeDialog()
? Or would that be overkill ?
[1]
CTK/Libs/Widgets/ctkFileDialog.cpp
Line 54 in c4f1eee
bool UsingNativeDialog; |
ctkFileDialog now uses the native dialog by default which was causing an issue.
0c2fc7c
to
0cec298
Compare
Doesn't matter to me. If you think ivar's need a method associated with them instead of getting them directly, I could change it. |
0cec298
to
5cf320a
Compare
@jamesobutler I just fixed up the commit message prefix to be Regex is the same one ... |
If we need to check for the status of the widget in application code, we may want to revisit. In the meantime, no need for it. |
Following up to #973, this makes changes for ctkDICOMBrowser to not crash on initialization. @lassoan Would you like to make the additional DICOM related changes here now that the "Copy" import mode wouldn't be used? I'm a user that does not do any DICOM work so I do not know what would be appropriate behavior.